Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: utils/tests/pub/validator/utf8_readme_test.dart

Issue 13375022: Split up some slow pub tests and mark some scheduled_test tests as slow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/tests/pub/validator/size_test.dart ('k') | utils/tests/pub/validator/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/validator/utf8_readme_test.dart
diff --git a/utils/tests/pub/validator/utf8_readme_test.dart b/utils/tests/pub/validator/utf8_readme_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..8d63c784fb3b2895d2fafb2e3c9503de9847a163
--- /dev/null
+++ b/utils/tests/pub/validator/utf8_readme_test.dart
@@ -0,0 +1,43 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:scheduled_test/scheduled_test.dart';
+
+import '../../../pub/entrypoint.dart';
+import '../../../pub/validator.dart';
+import '../../../pub/validator/utf8_readme.dart';
+import '../descriptor.dart' as d;
+import '../test_pub.dart';
+import 'utils.dart';
+
+Validator utf8Readme(Entrypoint entrypoint) =>
+ new Utf8ReadmeValidator(entrypoint);
+
+main() {
+ initConfig();
+
+ group('should consider a package valid if it', () {
+ setUp(d.validPackage.create);
+
+ integration('looks normal', () => expectNoValidationError(utf8Readme));
+
+ integration('has a non-primary readme with invalid utf-8', () {
+ d.dir(appPath, [
+ d.file("README", "Valid utf-8"),
+ d.binaryFile("README.invalid", [192])
+ ]).create();
+ expectNoValidationError(utf8Readme);
+ });
+ });
+
+ integration('should consider a package invalid if it has a README with '
+ 'invalid utf-8', () {
+ d.validPackage.create();
+
+ d.dir(appPath, [
+ d.binaryFile("README", [192])
+ ]).create();
+ expectValidationWarning(utf8Readme);
+ });
+}
« no previous file with comments | « utils/tests/pub/validator/size_test.dart ('k') | utils/tests/pub/validator/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698