Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: utils/tests/pub/validator/name_test.dart

Issue 13375022: Split up some slow pub tests and mark some scheduled_test tests as slow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/tests/pub/validator/license_test.dart ('k') | utils/tests/pub/validator/pubspec_field_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/validator/name_test.dart
diff --git a/utils/tests/pub/validator/name_test.dart b/utils/tests/pub/validator/name_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..9f0085b7e8189a871e6e567220a838166a333398
--- /dev/null
+++ b/utils/tests/pub/validator/name_test.dart
@@ -0,0 +1,107 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:pathos/path.dart' as path;
+import 'package:scheduled_test/scheduled_test.dart';
+
+import '../../../pub/entrypoint.dart';
+import '../../../pub/io.dart';
+import '../../../pub/validator.dart';
+import '../../../pub/validator/name.dart';
+import '../descriptor.dart' as d;
+import '../test_pub.dart';
+import 'utils.dart';
+
+Validator name(Entrypoint entrypoint) => new NameValidator(entrypoint);
+
+main() {
+ initConfig();
+
+ group('should consider a package valid if it', () {
+ setUp(d.validPackage.create);
+
+ integration('looks normal', () => expectNoValidationError(name));
+
+ integration('has a badly-named library in lib/src', () {
+ d.dir(appPath, [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [
+ d.file("test_pkg.dart", "int i = 1;"),
+ d.dir("src", [d.file("8ball.dart", "int j = 2;")])
+ ])
+ ]).create();
+ expectNoValidationError(name);
+ });
+ });
+
+ group('should consider a package invalid if it', () {
+ setUp(d.validPackage.create);
+
+ integration('has an empty package name', () {
+ d.dir(appPath, [d.libPubspec("", "1.0.0")]).create();
+ expectValidationError(name);
+ });
+
+ integration('has a package name with an invalid character', () {
+ d.dir(appPath, [d.libPubspec("test-pkg", "1.0.0")]).create();
+ expectValidationError(name);
+ });
+
+ integration('has a package name that begins with a number', () {
+ d.dir(appPath, [d.libPubspec("8ball", "1.0.0")]).create();
+ expectValidationError(name);
+ });
+
+ integration('has a package name that contains upper-case letters', () {
+ d.dir(appPath, [d.libPubspec("TestPkg", "1.0.0")]).create();
+ expectValidationWarning(name);
+ });
+
+ integration('has a package name that is a Dart reserved word', () {
+ d.dir(appPath, [d.libPubspec("final", "1.0.0")]).create();
+ expectValidationError(name);
+ });
+
+ integration('has a library name with an invalid character', () {
+ d.dir(appPath, [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("test-pkg.dart", "int i = 0;")])
+ ]).create();
+ expectValidationWarning(name);
+ });
+
+ integration('has a library name that begins with a number', () {
+ d.dir(appPath, [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("8ball.dart", "int i = 0;")])
+ ]).create();
+ expectValidationWarning(name);
+ });
+
+ integration('has a library name that contains upper-case letters', () {
+ d.dir(appPath, [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("TestPkg.dart", "int i = 0;")])
+ ]).create();
+ expectValidationWarning(name);
+ });
+
+ integration('has a library name that is a Dart reserved word', () {
+ d.dir(appPath, [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("for.dart", "int i = 0;")])
+ ]).create();
+ expectValidationWarning(name);
+ });
+
+ integration('has a single library named differently than the package', () {
+ schedule(() =>
+ deleteEntry(path.join(sandboxDir, appPath, "lib", "test_pkg.dart")));
+ d.dir(appPath, [
+ d.dir("lib", [d.file("best_pkg.dart", "int i = 0;")])
+ ]).create();
+ expectValidationWarning(name);
+ });
+ });
+}
« no previous file with comments | « utils/tests/pub/validator/license_test.dart ('k') | utils/tests/pub/validator/pubspec_field_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698