Issue 1315523012: dart2js ssa: Open coding of removeLast should use -1 as index

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1315523012: dart2js ssa: Open coding of removeLast should use -1 as index (Closed)

Created:
5 years, 3 months ago by sra1

Modified:
5 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js ssa: Open coding of removeLast should use -1 as index This makes the error consistent between unoptimized and optimizer code. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1aa97c36b5fbac5454f5a2c428e923874214588e

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -3 lines)			Patch
M	pkg/compiler/lib/src/ssa/codegen.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/nodes.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/optimize.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/js_array.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/compiler/dart2js_extra/js_array_removeLast_error_test.dart	View	1 chunk	+39 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

sra1

5 years, 3 months ago (2015-09-10 22:39:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:40001) manually as
1aa97c36b5fbac5454f5a2c428e923874214588e (presubmit successful).