pkg/compiler/lib/src/ssa/codegen.dart - Issue 1315523012: dart2js ssa: Open coding of removeLast should use -1 as index

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 1315523012: dart2js ssa: Open coding of removeLast should use -1 as index (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/codegen.dart

diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart

index 6a2002c1143251454329fc2a00856c19f099db68..3739c838f6f1ab03954887d53a4a1c3a7af5a352 100644

--- a/pkg/compiler/lib/src/ssa/codegen.dart

+++ b/pkg/compiler/lib/src/ssa/codegen.dart

@@ -2122,7 +2122,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

js.Statement thenBody = new js.Block.empty();

js.Block oldContainer = currentContainer;

currentContainer = thenBody;

- generateThrowWithHelper('ioore', [node.array, node.index]);

+ generateThrowWithHelper('ioore', [node.array, node.reportedIndex]);

currentContainer = oldContainer;

thenBody = unwrapStatement(thenBody);

pushStatement(new js.If.noElse(underOver, thenBody)

« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »