sdk/lib/_internal/js_runtime/lib/js_array.dart - Issue 1315523012: dart2js ssa: Open coding of removeLast should use -1 as index

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/js_runtime/lib/js_array.dart

Issue 1315523012: dart2js ssa: Open coding of removeLast should use -1 as index (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/js_runtime/lib/js_array.dart

diff --git a/sdk/lib/_internal/js_runtime/lib/js_array.dart b/sdk/lib/_internal/js_runtime/lib/js_array.dart

index 51a8fb4dc1ee4eb3eeac3bff547ed79dace4ab5e..e3951e74406005f507578fa9ff33aa20af4e9d82 100644

--- a/sdk/lib/_internal/js_runtime/lib/js_array.dart

+++ b/sdk/lib/_internal/js_runtime/lib/js_array.dart

@@ -150,7 +150,7 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

E removeLast() {

checkGrowable('removeLast');

- if (length == 0) throw new RangeError.value(-1);

+ if (length == 0) throw diagnoseIndexError(this, -1);

return JS('var', r'#.pop()', this);

}