Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314573002: Use Name instead of Selector in SemanticSendVisitor (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -602 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 3 chunks +13 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 5 chunks +6 lines, -5 lines 1 comment Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 7 chunks +22 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +58 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 4 chunks +24 lines, -9 lines 3 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 35 chunks +56 lines, -85 lines 2 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 16 chunks +16 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 45 chunks +85 lines, -140 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 27 chunks +42 lines, -125 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 10 chunks +13 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 12 chunks +12 lines, -40 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 11 chunks +49 lines, -64 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
Main changes in semantic_visitor.dart and universe.dart
5 years, 4 months ago (2015-08-24 09:38:25 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1314573002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/1314573002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart#newcode2577 pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:2577: new Selector.call(target.memberName, new CallStructure(arguments.length)); long line. https://codereview.chromium.org/1314573002/diff/1/pkg/compiler/lib/src/resolution/access_semantics.dart File ...
5 years, 4 months ago (2015-08-24 14:15:13 UTC) #3
Siggi Cherem (dart-lang)
lgtm
5 years, 3 months ago (2015-08-24 16:57:29 UTC) #5
Johnni Winther
5 years, 3 months ago (2015-08-25 08:03:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6b156993dbd06b47069fde39f3869ea0163786c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698