tests/compiler/dart2js/patch_test.dart - Issue 1314573002: Use Name instead of Selector in SemanticSendVisitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/patch_test.dart

Issue 1314573002: Use Name instead of Selector in SemanticSendVisitor (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/resolution/members.dart ('K') | « tests/compiler/dart2js/cpa_inference_test.dart ('k') | tests/compiler/dart2js/semantic_visitor_test_send_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/patch_test.dart

diff --git a/tests/compiler/dart2js/patch_test.dart b/tests/compiler/dart2js/patch_test.dart

index 64f7f5858745e9c8ec2a104b86cc68c106593081..19818425804bf8c418d88bbf5fcb8a8e8b705383 100644

--- a/tests/compiler/dart2js/patch_test.dart

+++ b/tests/compiler/dart2js/patch_test.dart

@@ -6,12 +6,15 @@ import 'dart:async';

import 'package:expect/expect.dart';

import 'package:async_helper/async_helper.dart';

import 'package:compiler/src/compiler.dart';

-import 'package:compiler/src/diagnostics/messages.dart' show MessageKind;

+import 'package:compiler/src/diagnostics/messages.dart' show

+ MessageKind;

import 'package:compiler/src/elements/elements.dart';

import 'package:compiler/src/elements/modelx.dart';

import 'package:compiler/src/tree/tree.dart';

import 'package:compiler/src/types/types.dart';

-import 'package:compiler/src/universe/universe.dart' show Selector;

+import 'package:compiler/src/universe/universe.dart' show

+ CallStructure,

+ Selector;

import 'package:compiler/src/world.dart';

import 'mock_compiler.dart';

@@ -872,7 +875,8 @@ testPatchAndSelector() {

// Check that a method just in the patch class is a target for a

// typed selector.

- Selector selector = new Selector.call(const PublicName('method'), 0);

+ Selector selector =

+ new Selector.call(const PublicName('method'), CallStructure.NO_ARGS);

TypeMask typeMask = new TypeMask.exact(cls, world);

FunctionElement method = cls.implementation.lookupLocalMember('method');

method.computeType(compiler);

@@ -881,7 +885,8 @@ testPatchAndSelector() {

// Check that the declaration method in the declaration class is a target

// for a typed selector.

- selector = new Selector.call(const PublicName('clear'), 0);

+ selector =

+ new Selector.call(const PublicName('clear'), CallStructure.NO_ARGS);

typeMask = new TypeMask.exact(cls, world);

method = cls.lookupLocalMember('clear');

method.computeType(compiler);