Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1314573002: Use Name instead of Selector in SemanticSendVisitor (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 4a2f3e0de7ed64455e5387e51c9ff41b48e6a96d..fb0f231c080395f3df096661daee2d846a526602 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -2471,7 +2471,8 @@ class SsaBuilder extends ast.Visitor
<HInstruction>[buildFunctionType(type), original];
pushInvokeDynamic(
null,
- new Selector.call(new Name(name, backend.jsHelperLibrary), 1),
+ new Selector.call(
+ new Name(name, backend.jsHelperLibrary), CallStructure.ONE_ARG),
null,
arguments);
@@ -3473,7 +3474,7 @@ class SsaBuilder extends ast.Visitor
void visitDynamicPropertyGet(
ast.Send node,
ast.Node receiver,
- Selector selector,
+ Name name,
_) {
generateDynamicGet(node);
}
@@ -3482,7 +3483,7 @@ class SsaBuilder extends ast.Visitor
void visitIfNotNullDynamicPropertyGet(
ast.Send node,
ast.Node receiver,
- Selector selector,
+ Name name,
_) {
// exp?.x compiled as:
// t1 = exp;
@@ -3555,7 +3556,7 @@ class SsaBuilder extends ast.Visitor
@override
void visitThisPropertyGet(
ast.Send node,
- Selector selector,
+ Name name,
_) {
generateDynamicGet(node);
}
@@ -3754,7 +3755,9 @@ class SsaBuilder extends ast.Visitor
List arguments = [buildFunctionType(type), expression];
pushInvokeDynamic(
node,
- new Selector.call(new Name('_isTest', backend.jsHelperLibrary), 1),
+ new Selector.call(
+ new PrivateName('_isTest', backend.jsHelperLibrary),
+ CallStructure.ONE_ARG),
null,
arguments);
return new HIs.compound(type, expression, pop(), backend.boolType);
@@ -3936,7 +3939,7 @@ class SsaBuilder extends ast.Visitor
ast.Send node,
ast.Node expression,
ast.NodeList arguments,
- Selector selector,
+ CallStructure callStructure,
_) {
generateCallInvoke(
node,
@@ -6346,7 +6349,7 @@ class SsaBuilder extends ast.Visitor
@override
void visitThisPropertySet(
ast.SendSet node,
- Selector selector,
+ Name name,
ast.Node rhs,
_) {
generateInstanceSetterWithCompiledReceiver(
@@ -6359,7 +6362,7 @@ class SsaBuilder extends ast.Visitor
void visitDynamicPropertySet(
ast.SendSet node,
ast.Node receiver,
- Selector selector,
+ Name name,
ast.Node rhs,
_) {
generateInstanceSetterWithCompiledReceiver(
@@ -6372,7 +6375,7 @@ class SsaBuilder extends ast.Visitor
void visitIfNotNullDynamicPropertySet(
ast.SendSet node,
ast.Node receiver,
- Selector selector,
+ Name name,
ast.Node rhs,
_) {
// compile e?.x = e2 to:
@@ -6697,9 +6700,8 @@ class SsaBuilder extends ast.Visitor
void handleDynamicCompounds(
ast.Send node,
ast.Node receiver,
+ Name name,
CompoundRhs rhs,
- Selector getterSelector,
- Selector setterSelector,
_) {
handleCompoundSendSet(node);
}

Powered by Google App Engine
This is Rietveld 408576698