Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1313113002: Fix display of parameter lists in servers Element structure (issue 24194) (Closed)

Created:
5 years, 4 months ago by Brian Wilkerson
Modified:
5 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix display of parameter lists in servers Element structure (issue 24194) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/4bd6b4b0485023785ebe89fae59df3d33495ca3b

Patch Set 1 #

Patch Set 2 : formatted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -30 lines) Patch
M pkg/analysis_server/lib/src/protocol_server.dart View 1 3 chunks +10 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 5 chunks +32 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 4 months ago (2015-08-25 16:18:11 UTC) #2
scheglov
LGTM
5 years, 4 months ago (2015-08-25 16:20:57 UTC) #3
Brian Wilkerson
5 years, 4 months ago (2015-08-25 16:23:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4bd6b4b0485023785ebe89fae59df3d33495ca3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698