Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

Issue 1313113002: Fix display of parameter lists in servers Element structure (issue 24194) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: formatted Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/protocol_server_test.dart ('k') | pkg/analyzer/lib/src/generated/element.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
index 643a24a3884b078aa29b22327df438fb4aee2a05..a539532a76ec10518335985713a9ed386369b341 100644
--- a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
@@ -127,7 +127,8 @@ class ImportedReferenceContributorTest extends AbstractSelectorSuggestionTest {
@override
CompletionSuggestion assertSuggestImportedClass(String name,
{CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
- int relevance: DART_RELEVANCE_DEFAULT, String importUri,
+ int relevance: DART_RELEVANCE_DEFAULT,
+ String importUri,
String elemFile}) {
return assertSuggestClass(name,
relevance: relevance,
@@ -526,8 +527,7 @@ main() {new ^ String x = "hello";}''');
expect(suggestion.hasNamedParameters, false);
suggestion = assertSuggestImportedConstructor('C.bar');
- expect(
- suggestion.element.parameters, "({dynamic boo: 'hoo'}, {int z: 0})");
+ expect(suggestion.element.parameters, "({dynamic boo: 'hoo', int z: 0})");
expect(suggestion.parameterNames, hasLength(2));
expect(suggestion.parameterNames[0], 'boo');
expect(suggestion.parameterTypes[0], 'dynamic');
« no previous file with comments | « pkg/analysis_server/test/protocol_server_test.dart ('k') | pkg/analyzer/lib/src/generated/element.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698