Fix display of parameter lists in servers Element structure (issue 24194)

pkg/analysis_server/lib/src/protocol_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protocol.server;
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart'
     as engine;
 import 'package:analyzer/src/generated/ast.dart' as engine;
@@ skipping 87 matching lines @@
 
 /**
  * Construct based on a value from the analyzer engine.
  */
 Element newElement_fromEngine(engine.Element element) {
   String name = element.displayName;
   String elementTypeParameters = _getTypeParametersString(element);
   String elementParameters = _getParametersString(element);
   String elementReturnType = getReturnTypeString(element);
   ElementKind kind = newElementKind_fromEngineElement(element);
-  return new Element(kind, name, Element.makeFlags(
+  return new Element(
+      kind,
+      name,
+      Element.makeFlags(
           isPrivate: element.isPrivate,
           isDeprecated: element.isDeprecated,
           isAbstract: _isAbstract(element),
           isConst: _isConst(element),
           isFinal: _isFinal(element),
           isStatic: _isStatic(element)),
       location: newLocation_fromElement(element),
       typeParameters: elementTypeParameters,
       parameters: elementParameters,
       returnType: elementReturnType);
@@ skipping 58 matching lines @@
   return ElementKind.UNKNOWN;
 }
 
 /**
  * Construct based on a value from the analyzer engine.
  */
 ElementKind newElementKind_fromEngineElement(engine.Element element) {
   if (element is engine.ClassElement && element.isEnum) {
     return ElementKind.ENUM;
   }
-  if (element is engine.FieldElement && element.isEnumConstant &&
+  if (element is engine.FieldElement &&
+      element.isEnumConstant &&
       // MyEnum.values and MyEnum.one.index return isEnumConstant = true
       // so these additional checks are necessary.
       // TODO(danrubel) MyEnum.values is constant, but is a list
       // so should it return isEnumConstant = true?
       // MyEnum.one.index is final but *not* constant
       // so should it return isEnumConstant = true?
       // Or should we return ElementKind.ENUM_CONSTANT here
       // in either or both of these cases?
       element.type != null &&
       element.type.element == element.enclosingElement) {
@@ skipping 148 matching lines @@
   } else {
     return null;
   }
   StringBuffer sb = new StringBuffer();
   String closeOptionalString = '';
   for (engine.ParameterElement parameter in parameters) {
     if (sb.isNotEmpty) {
       sb.write(', ');
     }
     if (closeOptionalString.isEmpty) {
-      if (parameter.kind == engine.ParameterKind.NAMED) {
+      engine.ParameterKind kind = parameter.parameterKind;
+      if (kind == engine.ParameterKind.NAMED) {
         sb.write('{');
         closeOptionalString = '}';
       }
-      if (parameter.kind == engine.ParameterKind.POSITIONAL) {
+      if (kind == engine.ParameterKind.POSITIONAL) {
         sb.write('[');
         closeOptionalString = ']';
       }
     }
-    sb.write(parameter.toString());
+    parameter.appendToWithoutDelimiters(sb);
   }
   sb.write(closeOptionalString);
   return '(' + sb.toString() + ')';
 }
 
 String _getTypeParametersString(engine.Element element) {
   List<engine.TypeParameterElement> typeParameters;
   if (element is engine.ClassElement) {
     typeParameters = element.typeParameters;
   } else if (element is engine.FunctionTypeAliasElement) {
@@ skipping 61 matching lines @@
     if (lineInfo != null) {
       engine.LineInfo_Location offsetLocation =
           lineInfo.getLocation(range.offset);
       startLine = offsetLocation.lineNumber;
       startColumn = offsetLocation.columnNumber;
     }
   }
   return new Location(
       source.fullName, range.offset, range.length, startLine, startColumn);
 }