Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1308993008: Add version validation for LookupMap, also add unittest directly in LookupMap (take 2) (Closed)

Created:
5 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add version validation for LookupMap, also add unittest directly in LookupMap (take 2) BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/f348b8b01c135666762df44df55282d3ce648983

Patch Set 1 #

Patch Set 2 : fix on top of previous CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -11 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 5 chunks +61 lines, -9 lines 0 comments Download
M pkg/lookup_map/lib/lookup_map.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/lookup_map/pubspec.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/lookup_map/test/lookup_map_test.dart View 1 chunk +74 lines, -0 lines 0 comments Download
A pkg/lookup_map/test/version_check_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
I reverted the previous CL because I saw a lot of breakage. Turns out the ...
5 years, 3 months ago (2015-09-04 21:11:56 UTC) #2
sra1
lgtm
5 years, 3 months ago (2015-09-04 21:23:58 UTC) #3
Siggi Cherem (dart-lang)
5 years, 3 months ago (2015-09-04 21:24:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f348b8b01c135666762df44df55282d3ce648983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698