pkg/pkg.status - Issue 1308993008: Add version validation for LookupMap, also add unittest directly in LookupMap (take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/pkg.status

Issue 1308993008: Add version validation for LookupMap, also add unittest directly in LookupMap (take 2) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix on top of previous CL Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/pkg.status

diff --git a/pkg/pkg.status b/pkg/pkg.status

index 5877a4290e295060097d67339e7654e3b6b91e4d..83c219175292e06c23ed5273859f3b21572dc43d 100644

--- a/pkg/pkg.status

+++ b/pkg/pkg.status

@@ -107,6 +107,7 @@ analyzer/test/src/task/incremental_element_builder_test: Pass, Slow # Issue 2162

analyzer/test/src/task/inputs_test: Pass, Slow # Issue 21628

analyzer/test/src/task/manager_test: Pass, Slow # Issue 21628

analyzer/test/src/task/model_test: Pass, Slow # Issue 21628

+lookup_map/test/version_check_test: SkipByDesign # Only meant to run in vm.

[ $runtime == jsshell ]

async/test/stream_zip_test: RuntimeError, OK # Timers are not supported.

« no previous file with comments | « pkg/lookup_map/test/version_check_test.dart ('k') | tests/compiler/dart2js/mock_libraries.dart » ('j') | no next file with comments »