Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: pkg/compiler/lib/src/diagnostics/messages.dart

Issue 1308993008: Add version validation for LookupMap, also add unittest directly in LookupMap (take 2) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix on top of previous CL Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * The messages in this file should meet the following guide lines: 7 * The messages in this file should meet the following guide lines:
8 * 8 *
9 * 1. The message should be a complete sentence starting with an uppercase 9 * 1. The message should be a complete sentence starting with an uppercase
10 * letter, and ending with a period. 10 * letter, and ending with a period.
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 UNIMPLEMENTED_GETTER, 414 UNIMPLEMENTED_GETTER,
415 UNIMPLEMENTED_GETTER_ONE, 415 UNIMPLEMENTED_GETTER_ONE,
416 UNIMPLEMENTED_IMPLICIT_GETTER, 416 UNIMPLEMENTED_IMPLICIT_GETTER,
417 UNIMPLEMENTED_IMPLICIT_SETTER, 417 UNIMPLEMENTED_IMPLICIT_SETTER,
418 UNIMPLEMENTED_METHOD, 418 UNIMPLEMENTED_METHOD,
419 UNIMPLEMENTED_METHOD_CONT, 419 UNIMPLEMENTED_METHOD_CONT,
420 UNIMPLEMENTED_METHOD_ONE, 420 UNIMPLEMENTED_METHOD_ONE,
421 UNIMPLEMENTED_SETTER, 421 UNIMPLEMENTED_SETTER,
422 UNIMPLEMENTED_SETTER_ONE, 422 UNIMPLEMENTED_SETTER_ONE,
423 UNMATCHED_TOKEN, 423 UNMATCHED_TOKEN,
424 UNRECOGNIZED_VERSION_OF_LOOKUP_MAP,
424 UNSUPPORTED_BANG_EQ_EQ, 425 UNSUPPORTED_BANG_EQ_EQ,
425 UNSUPPORTED_EQ_EQ_EQ, 426 UNSUPPORTED_EQ_EQ_EQ,
426 UNSUPPORTED_LITERAL_SYMBOL, 427 UNSUPPORTED_LITERAL_SYMBOL,
427 UNSUPPORTED_PREFIX_PLUS, 428 UNSUPPORTED_PREFIX_PLUS,
428 UNSUPPORTED_THROW_WITHOUT_EXP, 429 UNSUPPORTED_THROW_WITHOUT_EXP,
429 UNTERMINATED_COMMENT, 430 UNTERMINATED_COMMENT,
430 UNTERMINATED_STRING, 431 UNTERMINATED_STRING,
431 UNTERMINATED_TOKEN, 432 UNTERMINATED_TOKEN,
432 UNUSED_CLASS, 433 UNUSED_CLASS,
433 UNUSED_LABEL, 434 UNUSED_LABEL,
(...skipping 2854 matching lines...) Expand 10 before | Expand all | Expand 10 after
3288 "will be able to perform more optimizations if it is rewritten.", 3289 "will be able to perform more optimizations if it is rewritten.",
3289 howToFix: "Rewrite to " 3290 howToFix: "Rewrite to "
3290 "'noSuchMethod(Invocation i) => super.noSuchMethod(i);'."), 3291 "'noSuchMethod(Invocation i) => super.noSuchMethod(i);'."),
3291 3292
3292 MessageKind.COMPLEX_RETURNING_NSM: 3293 MessageKind.COMPLEX_RETURNING_NSM:
3293 const MessageTemplate(MessageKind.COMPLEX_RETURNING_NSM, 3294 const MessageTemplate(MessageKind.COMPLEX_RETURNING_NSM,
3294 "Overriding 'noSuchMethod' causes the compiler to generate " 3295 "Overriding 'noSuchMethod' causes the compiler to generate "
3295 "more code and prevents the compiler from doing some optimizations.", 3296 "more code and prevents the compiler from doing some optimizations.",
3296 howToFix: "Consider removing this 'noSuchMethod' implementation."), 3297 howToFix: "Consider removing this 'noSuchMethod' implementation."),
3297 3298
3299 MessageKind.UNRECOGNIZED_VERSION_OF_LOOKUP_MAP:
3300 const MessageTemplate(MessageKind.UNRECOGNIZED_VERSION_OF_LOOKUP_MAP,
3301 "Unsupported version of package:lookup_map.",
3302 howToFix: DONT_KNOW_HOW_TO_FIX),
3298 3303
3299 }; // End of TEMPLATES. 3304 }; // End of TEMPLATES.
3300 3305
3301 static const String IMPORT_EXPERIMENTAL_MIRRORS_PADDING = '\n* '; 3306 static const String IMPORT_EXPERIMENTAL_MIRRORS_PADDING = '\n* ';
3302 3307
3303 toString() => template; 3308 toString() => template;
3304 3309
3305 Message message([Map arguments = const {}, bool terse = false]) { 3310 Message message([Map arguments = const {}, bool terse = false]) {
3306 return new Message(this, arguments, terse); 3311 return new Message(this, arguments, terse);
3307 } 3312 }
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
3357 static String convertToString(value) { 3362 static String convertToString(value) {
3358 if (value is ErrorToken) { 3363 if (value is ErrorToken) {
3359 // Shouldn't happen. 3364 // Shouldn't happen.
3360 return value.assertionMessage; 3365 return value.assertionMessage;
3361 } else if (value is Token) { 3366 } else if (value is Token) {
3362 value = value.value; 3367 value = value.value;
3363 } 3368 }
3364 return '$value'; 3369 return '$value';
3365 } 3370 }
3366 } 3371 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698