better warning in tools/testing/dart/test_options

better warning in tools/testing/dart/test_options

Less helpful: Warning: combination of none and firefox is invalid.
More helpful: Warning: combination of compiler 'none' and runtime 'firefox' is invalid.

Committed: https://code.google.com/p/dart/source/detail?r=20512

[kevmoo-old, 2013-03-26 01:11:16]

PTAL

[kustermann, 2013-03-26 08:27:26]

lgtm

https://codereview.chromium.org/13079005/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/13079005/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:457: "Skipping this combination.");
Indentation.

[kevmoo-old, 2013-03-26 13:16:38]

https://codereview.chromium.org/13079005/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/13079005/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:457: "Skipping this combination.");
On 2013/03/26 08:27:26, kustermann wrote:
> Indentation.

Explain...

[kevmoo-old, 2013-03-26 13:20:46]

Committed patchset #1 manually as r20512 (presubmit successful).

[kustermann, 2013-03-26 13:43:07]

https://codereview.chromium.org/13079005/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/13079005/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:457: "Skipping this combination.");
On 2013/03/26 13:16:38, kevmoo wrote:
> On 2013/03/26 08:27:26, kustermann wrote:
> > Indentation.
> 
> Explain...

AFAIK we indent the two following lines to the same level as the "Warning"
(since it's the same argument).
       print("Warning: combination of compiler '${config['compiler']}' and "
             "runtime '${config['runtime']}' is invalid. "
             "Skipping this combination.");
instead of:
       print("Warning: combination of compiler '${config['compiler']}' and "
           "runtime '${config['runtime']}' is invalid. "
           "Skipping this combination.");

See for example lines 467/468. (there are a couple of places where it's wrong).