better warning in tools/testing/dart/test_options

tools/testing/dart/test_options.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_options_parser;
 
 import "dart:io";
 import "dart:math";
 import "drt_updater.dart";
 import "test_suite.dart";
@@ skipping 434 matching lines @@
       case 'new_analyzer':
         validRuntimes = const ['none'];
         break;
       case 'none':
       case 'dart2dart':
         validRuntimes = const ['vm', 'drt', 'dartium'];
         break;
     }
     if (!validRuntimes.contains(config['runtime'])) {
       isValid = false;
-      print("Warning: combination of ${config['compiler']} and "
-          "${config['runtime']} is invalid. Skipping this combination.");
+      print("Warning: combination of compiler '${config['compiler']}' and "
+          "runtime '${config['runtime']}' is invalid. "
+          "Skipping this combination.");

[kustermann, 2013/03/26 08:27:26]

Indentation.

[kevmoo-old, 2013/03/26 13:16:38]

Explain...

[kustermann, 2013/03/26 13:43:07]

AFAIK we indent the two following lines to the same level as the "Warning"
(since it's the same argument).
       print("Warning: combination of compiler '${config['compiler']}' and "
             "runtime '${config['runtime']}' is invalid. "
             "Skipping this combination.");
instead of:
       print("Warning: combination of compiler '${config['compiler']}' and "
           "runtime '${config['runtime']}' is invalid. "
           "Skipping this combination.");

See for example lines 467/468. (there are a couple of places where it's wrong).

     }
     if ((config['runtime'] == 'ie9' || config['runtime'] == 'ie10') &&
         Platform.operatingSystem != 'windows') {
       isValid = false;
       print("Warning cannot run Internet Explorer on non-Windows operating"
           " system.");
     }
     if (config['shard'] < 1 || config['shard'] > config['shards']) {
       isValid = false;
       print("Error: shard index is ${config['shard']} out of "
@@ skipping 231 matching lines @@
         return option;
       }
     }
     print('Unknown test option $name');
     exit(1);
   }
 
 
   List<_TestOptionSpecification> _options;
 }