better warning in tools/testing/dart/test_options

tools/testing/dart/test_options.dart

Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index a7f7983255cd37c1104c3d731b70626a43174d9b..d751ab476921757773d2c4c4cc4fc2bc9db318b9 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -452,8 +452,9 @@ Note: currently only implemented for dart2js.''',
     }
     if (!validRuntimes.contains(config['runtime'])) {
       isValid = false;
-      print("Warning: combination of ${config['compiler']} and "
-          "${config['runtime']} is invalid. Skipping this combination.");
+      print("Warning: combination of compiler '${config['compiler']}' and "
+          "runtime '${config['runtime']}' is invalid. "
+          "Skipping this combination.");

[kustermann, 2013/03/26 08:27:26]

Indentation.

[kevmoo-old, 2013/03/26 13:16:38]

Explain...

[kustermann, 2013/03/26 13:43:07]

AFAIK we indent the two following lines to the same level as the "Warning"
(since it's the same argument).
       print("Warning: combination of compiler '${config['compiler']}' and "
             "runtime '${config['runtime']}' is invalid. "
             "Skipping this combination.");
instead of:
       print("Warning: combination of compiler '${config['compiler']}' and "
           "runtime '${config['runtime']}' is invalid. "
           "Skipping this combination.");

See for example lines 467/468. (there are a couple of places where it's wrong).

     }
     if ((config['runtime'] == 'ie9' || config['runtime'] == 'ie10') &&
         Platform.operatingSystem != 'windows') {