Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1304243008: Load predefined symbols address via Thread. (Closed)

Created:
5 years, 3 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -68 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 chunks +2 lines, -18 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 3 months ago (2015-09-03 23:21:28 UTC) #2
Florian Schneider
lgtm
5 years, 3 months ago (2015-09-04 07:59:46 UTC) #3
rmacnak
5 years, 3 months ago (2015-09-04 17:32:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f5adc134685507ee49eb6b9d860ec42ecb9a41d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698