Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Side by Side Diff: runtime/vm/intrinsifier_arm64.cc

Issue 1304243008: Load predefined symbols address via Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 1718 matching lines...) Expand 10 before | Expand all | Expand 10 after
1729 __ cmp(R1, Operand(R2)); 1729 __ cmp(R1, Operand(R2));
1730 __ b(&fall_through, CS); // Runtime throws exception. 1730 __ b(&fall_through, CS); // Runtime throws exception.
1731 1731
1732 __ CompareClassId(R0, kOneByteStringCid); 1732 __ CompareClassId(R0, kOneByteStringCid);
1733 __ b(&try_two_byte_string, NE); 1733 __ b(&try_two_byte_string, NE);
1734 __ SmiUntag(R1); 1734 __ SmiUntag(R1);
1735 __ AddImmediate(R0, R0, OneByteString::data_offset() - kHeapObjectTag); 1735 __ AddImmediate(R0, R0, OneByteString::data_offset() - kHeapObjectTag);
1736 __ ldr(R1, Address(R0, R1), kUnsignedByte); 1736 __ ldr(R1, Address(R0, R1), kUnsignedByte);
1737 __ CompareImmediate(R1, Symbols::kNumberOfOneCharCodeSymbols); 1737 __ CompareImmediate(R1, Symbols::kNumberOfOneCharCodeSymbols);
1738 __ b(&fall_through, GE); 1738 __ b(&fall_through, GE);
1739 const ExternalLabel symbols_label( 1739 __ ldr(R0, Address(THR, Thread::predefined_symbols_address_offset()));
1740 reinterpret_cast<uword>(Symbols::PredefinedAddress()));
1741 __ TagAndPushPP();
1742 __ LoadPoolPointer();
1743 __ LoadExternalLabel(R0, &symbols_label);
1744 __ PopAndUntagPP();
1745 __ AddImmediate( 1740 __ AddImmediate(
1746 R0, R0, Symbols::kNullCharCodeSymbolOffset * kWordSize); 1741 R0, R0, Symbols::kNullCharCodeSymbolOffset * kWordSize);
1747 __ ldr(R0, Address(R0, R1, UXTX, Address::Scaled)); 1742 __ ldr(R0, Address(R0, R1, UXTX, Address::Scaled));
1748 __ ret(); 1743 __ ret();
1749 1744
1750 __ Bind(&try_two_byte_string); 1745 __ Bind(&try_two_byte_string);
1751 __ CompareClassId(R0, kTwoByteStringCid); 1746 __ CompareClassId(R0, kTwoByteStringCid);
1752 __ b(&fall_through, NE); 1747 __ b(&fall_through, NE);
1753 ASSERT(kSmiTagShift == 1); 1748 ASSERT(kSmiTagShift == 1);
1754 __ AddImmediate(R0, R0, TwoByteString::data_offset() - kHeapObjectTag); 1749 __ AddImmediate(R0, R0, TwoByteString::data_offset() - kHeapObjectTag);
1755 __ ldr(R1, Address(R0, R1), kUnsignedHalfword); 1750 __ ldr(R1, Address(R0, R1), kUnsignedHalfword);
1756 __ CompareImmediate(R1, Symbols::kNumberOfOneCharCodeSymbols); 1751 __ CompareImmediate(R1, Symbols::kNumberOfOneCharCodeSymbols);
1757 __ b(&fall_through, GE); 1752 __ b(&fall_through, GE);
1758 __ TagAndPushPP(); 1753 __ ldr(R0, Address(THR, Thread::predefined_symbols_address_offset()));
1759 __ LoadPoolPointer();
1760 __ LoadExternalLabel(R0, &symbols_label);
1761 __ PopAndUntagPP();
1762 __ AddImmediate( 1754 __ AddImmediate(
1763 R0, R0, Symbols::kNullCharCodeSymbolOffset * kWordSize); 1755 R0, R0, Symbols::kNullCharCodeSymbolOffset * kWordSize);
1764 __ ldr(R0, Address(R0, R1, UXTX, Address::Scaled)); 1756 __ ldr(R0, Address(R0, R1, UXTX, Address::Scaled));
1765 __ ret(); 1757 __ ret();
1766 1758
1767 __ Bind(&fall_through); 1759 __ Bind(&fall_through);
1768 } 1760 }
1769 1761
1770 1762
1771 void Intrinsifier::StringBaseIsEmpty(Assembler* assembler) { 1763 void Intrinsifier::StringBaseIsEmpty(Assembler* assembler) {
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
2134 2126
2135 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) { 2127 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
2136 __ LoadIsolate(R0); 2128 __ LoadIsolate(R0);
2137 __ ldr(R0, Address(R0, Isolate::current_tag_offset())); 2129 __ ldr(R0, Address(R0, Isolate::current_tag_offset()));
2138 __ ret(); 2130 __ ret();
2139 } 2131 }
2140 2132
2141 } // namespace dart 2133 } // namespace dart
2142 2134
2143 #endif // defined TARGET_ARCH_ARM64 2135 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698