runtime/vm/intermediate_language_arm64.cc - Issue 1304243008: Load predefined symbols address via Thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 1304243008: Load predefined symbols address via Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_arm64.cc

diff --git a/runtime/vm/intermediate_language_arm64.cc b/runtime/vm/intermediate_language_arm64.cc

index 785d8f7e74662bd61a5824ab4f788a08f2b4bdf2..cec9cb895db9e2552f87af38b96332169e027b6a 100644

--- a/runtime/vm/intermediate_language_arm64.cc

+++ b/runtime/vm/intermediate_language_arm64.cc

@@ -850,8 +850,7 @@ void StringFromCharCodeInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

const Register char_code = locs()->in(0).reg();

const Register result = locs()->out(0).reg();

- ExternalLabel label(reinterpret_cast<uword>(Symbols::PredefinedAddress()));

- __ LoadExternalLabel(result, &label);

+ __ ldr(result, Address(THR, Thread::predefined_symbols_address_offset()));

__ AddImmediate(

result, result, Symbols::kNullCharCodeSymbolOffset * kWordSize);

__ SmiUntag(TMP, char_code); // Untag to use scaled adress mode.

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »