Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1298393004: Handle comparison of empty URIs (sdk/24126). (Closed)

Created:
5 years, 4 months ago by pquitslund
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, sethladd
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle comparison of empty URIs (sdk/24126). Fixes issue where `.packages` provides a key mapped to an empty value (https://github.com/dart-lang/sdk/issues/24126). R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e11ce8ba87952ee2efeb7ed8211801f6cb6d9c9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 2 chunks +28 lines, -24 lines 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 4 months ago (2015-08-19 18:16:43 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-19 18:18:04 UTC) #3
pquitslund
5 years, 4 months ago (2015-08-19 19:54:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e11ce8ba87952ee2efeb7ed8211801f6cb6d9c9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698