Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: pkg/analyzer/test/generated/source_factory_test.dart

Issue 1298393004: Handle comparison of empty URIs (sdk/24126). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/utilities_dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/source_factory_test.dart
diff --git a/pkg/analyzer/test/generated/source_factory_test.dart b/pkg/analyzer/test/generated/source_factory_test.dart
index e3ed1deeeba1599f670faf071c0e58c57491fcfc..c16f1f8f6e31aea1429bf116fc35cd25d3c503db 100644
--- a/pkg/analyzer/test/generated/source_factory_test.dart
+++ b/pkg/analyzer/test/generated/source_factory_test.dart
@@ -182,6 +182,9 @@ foo:http://www.google.com
isTrue);
expect(utils.startsWith(Uri.parse('/foo/bar'), Uri.parse('/foo/b')),
isFalse);
+ // Handle odd URIs (https://github.com/dart-lang/sdk/issues/24126)
+ expect(utils.startsWith(Uri.parse('/foo/bar'), Uri.parse('')), isFalse);
+ expect(utils.startsWith(Uri.parse(''), Uri.parse('/foo/bar')), isFalse);
});
});
});
« no previous file with comments | « pkg/analyzer/lib/src/generated/utilities_dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698