Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2022)

Unified Diff: pkg/analyzer/lib/src/generated/utilities_dart.dart

Issue 1298393004: Handle comparison of empty URIs (sdk/24126). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/source_factory_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/utilities_dart.dart
diff --git a/pkg/analyzer/lib/src/generated/utilities_dart.dart b/pkg/analyzer/lib/src/generated/utilities_dart.dart
index 042af48d99b0be6fb2d9a40bf551ee12254168b8..882d1826811c3609e769d55be5d836073e27ef8c 100644
--- a/pkg/analyzer/lib/src/generated/utilities_dart.dart
+++ b/pkg/analyzer/lib/src/generated/utilities_dart.dart
@@ -7,6 +7,34 @@ library engine.utilities.dart;
import 'java_core.dart';
/**
+ * Check whether [uri1] starts with (or 'is prefixed by') [uri2] by checking
+ * path segments.
+ */
+bool startsWith(Uri uri1, Uri uri2) {
+ List<String> uri1Segments = uri1.pathSegments;
+ List<String> uri2Segments = uri2.pathSegments.toList();
+ // Punt if empty (https://github.com/dart-lang/sdk/issues/24126)
+ if (uri2Segments.isEmpty) {
+ return false;
+ }
+ // Trim trailing empty segments ('/foo/' => ['foo', ''])
+ if (uri2Segments.last == '') {
+ uri2Segments.removeLast();
+ }
+
+ if (uri2Segments.length > uri1Segments.length) {
+ return false;
+ }
+
+ for (int i = 0; i < uri2Segments.length; ++i) {
+ if (uri2Segments[i] != uri1Segments[i]) {
+ return false;
+ }
+ }
+ return true;
+}
+
+/**
* The enumeration `ParameterKind` defines the different kinds of parameters. There are two
* basic kinds of parameters: required and optional. Optional parameters are further divided into
* two kinds: positional optional and named optional.
@@ -35,27 +63,3 @@ class ParameterKind extends Enum<ParameterKind> {
const ParameterKind(String name, int ordinal, this.isOptional)
: super(name, ordinal);
}
-
-/**
- * Check whether [uri1] starts with (or 'is prefixed by') [uri2] by checking
- * path segments.
- */
-bool startsWith(Uri uri1, Uri uri2) {
- List<String> uri1Segments = uri1.pathSegments;
- List<String> uri2Segments = uri2.pathSegments.toList();
- // Trim trailing empty segments ('/foo/' => ['foo', ''])
- if (uri2Segments.last == '') {
- uri2Segments.removeLast();
- }
-
- if (uri2Segments.length > uri1Segments.length) {
- return false;
- }
-
- for (int i = 0; i < uri2Segments.length; ++i) {
- if (uri2Segments[i] != uri1Segments[i]) {
- return false;
- }
- }
- return true;
-}
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/source_factory_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698