Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1295223002: Drop support for recording Dart objects in a timeline trace (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop support for recording Dart objects in a timeline trace BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/29c41e3624231a5d5b8ad0aa70e2db08dff29e66

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -79 lines) Patch
M runtime/vm/timeline.h View 1 7 chunks +0 lines, -16 lines 0 comments Download
M runtime/vm/timeline.cc View 4 chunks +0 lines, -63 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-17 22:28:20 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-08-17 22:29:20 UTC) #3
Cutch
5 years, 4 months ago (2015-08-17 22:30:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
29c41e3624231a5d5b8ad0aa70e2db08dff29e66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698