Drop support for recording Dart objects in a timeline trace

runtime/vm/timeline.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <cstdlib>
 
 #include "vm/isolate.h"
 #include "vm/json_stream.h"
 #include "vm/lockers.h"
 #include "vm/object.h"
@@ skipping 241 matching lines @@
       seq_(0) {
 }
 
 
 void TimelineStream::Init(const char* name, bool enabled) {
   name_ = name;
   enabled_ = enabled;
 }
 
 
-TimelineEvent* TimelineStream::StartEvent(const Object& obj) {
-  if (!enabled_ || (recorder_ == NULL)) {
-    return NULL;
-  }
-  ASSERT(name_ != NULL);
-  ASSERT(recorder_ != NULL);
-  TimelineEvent* event = recorder_->StartEvent(obj);
-  if (event != NULL) {
-    event->StreamInit(this);
-  }
-  return event;
-}
-
-
 TimelineEvent* TimelineStream::StartEvent() {
   if (!enabled_ || (recorder_ == NULL)) {
     return NULL;
   }
   ASSERT(name_ != NULL);
   TimelineEvent* event = recorder_->StartEvent();
   if (event != NULL) {
     event->StreamInit(this);
   }
   return event;
@@ skipping 200 matching lines @@
     }
     if (block->LowerTimeBound() < earliest_time) {
       earliest_time = block->LowerTimeBound();
       earliest_index = block_idx;
     }
   }
   return earliest_index;
 }
 
 
-void TimelineEventRingRecorder::VisitObjectPointers(
-    ObjectPointerVisitor* visitor) {
-  visitor->VisitPointer(reinterpret_cast<RawObject**>(&event_objects_));
-}
-
-
-TimelineEvent* TimelineEventRingRecorder::StartEvent(const Object& obj) {
-  TimelineEvent* event = StartEvent();
-  if (event == NULL) {
-    return NULL;
-  }
-  // Grab the thread's timeline event block which contains |event|.
-  Thread* thread = Thread::Current();
-  TimelineEventBlock* thread_block = thread->timeline_block();
-  ASSERT(thread_block != NULL);
-  ASSERT(thread_block->length() > 0);
-  const intptr_t block_index = thread_block->block_index();
-  const intptr_t event_objects_index =
-      block_index * TimelineEventBlock::kBlockSize + thread_block->length() - 1;
-  const Array& event_objects = Array::Handle(event_objects_);
-  event_objects.SetAt(event_objects_index, obj);
-  return event;
-}
-
-
 TimelineEvent* TimelineEventRingRecorder::StartEvent() {
   return ThreadBlockStartEvent();
 }
 
 
 void TimelineEventRingRecorder::CompleteEvent(TimelineEvent* event) {
   // no-op.
 }
 
 
 TimelineEventStreamingRecorder::TimelineEventStreamingRecorder() {
 }
 
 
 TimelineEventStreamingRecorder::~TimelineEventStreamingRecorder() {
 }
 
 
 void TimelineEventStreamingRecorder::PrintJSON(JSONStream* js) {
   JSONObject topLevel(js);
   topLevel.AddProperty("type", "_Timeline");
   {
     JSONArray events(&topLevel, "traceEvents");
     PrintJSONMeta(&events);
   }
 }
 
 
-void TimelineEventStreamingRecorder::VisitObjectPointers(
-    ObjectPointerVisitor* visitor) {
-  // no-op.
-}
-
-
-TimelineEvent* TimelineEventStreamingRecorder::StartEvent(
-    const Object& object) {
-  // The streaming recorder does not track Dart objects.
-  return StartEvent();
-}
-
-
 TimelineEvent* TimelineEventStreamingRecorder::StartEvent() {
   TimelineEvent* event = new TimelineEvent();
   return event;
 }
 
 
 void TimelineEventStreamingRecorder::CompleteEvent(TimelineEvent* event) {
   StreamEvent(event);
   delete event;
 }
@@ skipping 22 matching lines @@
   MutexLocker ml(&lock_);
   return GetNewBlockLocked();
 }
 
 
 TimelineEventBlock* TimelineEventEndlessRecorder::GetHeadBlock() {
   return head_;
 }
 
 
-void TimelineEventEndlessRecorder::VisitObjectPointers(
-    ObjectPointerVisitor* visitor) {
-  // no-op.
-}
-
-
-TimelineEvent* TimelineEventEndlessRecorder::StartEvent(const Object& object) {
-  return StartEvent();
-}
-
-
 TimelineEvent* TimelineEventEndlessRecorder::StartEvent() {
   return ThreadBlockStartEvent();
 }
 
 
 void TimelineEventEndlessRecorder::CompleteEvent(TimelineEvent* event) {
   // no-op.
 }
 
 
@@ skipping 137 matching lines @@
 
 
 TimelineEventBlock* TimelineEventBlockIterator::Next() {
   ASSERT(current_ != NULL);
   TimelineEventBlock* r = current_;
   current_ = current_->next();
   return r;
 }
 
 }  // namespace dart