Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: runtime/vm/timeline.h

Issue 1295223002: Drop support for recording Dart objects in a timeline trace (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.h
diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h
index 273df848e7546e4f3a77a8835aabcc190874b051..a57b651e5d6eaf17266c9cdbbafefa0b32986a24 100644
--- a/runtime/vm/timeline.h
+++ b/runtime/vm/timeline.h
@@ -196,11 +196,6 @@ class TimelineStream {
// Records an event. Will return |NULL| if not enabled. The returned
// |TimelineEvent| is in an undefined state and must be initialized.
- // |obj| is associated with the returned |TimelineEvent|.
- TimelineEvent* StartEvent(const Object& obj);
-
- // Records an event. Will return |NULL| if not enabled. The returned
- // |TimelineEvent| is in an undefined state and must be initialized.
TimelineEvent* StartEvent();
void CompleteEvent(TimelineEvent* event);
@@ -390,8 +385,6 @@ class TimelineEventRecorder {
protected:
// Interface method(s) which must be implemented.
- virtual void VisitObjectPointers(ObjectPointerVisitor* visitor) = 0;
- virtual TimelineEvent* StartEvent(const Object& object) = 0;
virtual TimelineEvent* StartEvent() = 0;
virtual void CompleteEvent(TimelineEvent* event) = 0;
@@ -412,7 +405,6 @@ class TimelineEventRecorder {
// A recorder that stores events in a ring buffer of fixed capacity.
-// This recorder does track Dart objects.
class TimelineEventRingRecorder : public TimelineEventRecorder {
public:
static const intptr_t kDefaultCapacity = 8192;
@@ -425,8 +417,6 @@ class TimelineEventRingRecorder : public TimelineEventRecorder {
TimelineEventBlock* GetHeadBlock();
protected:
- void VisitObjectPointers(ObjectPointerVisitor* visitor);
- TimelineEvent* StartEvent(const Object& object);
TimelineEvent* StartEvent();
void CompleteEvent(TimelineEvent* event);
@@ -444,7 +434,6 @@ class TimelineEventRingRecorder : public TimelineEventRecorder {
// An abstract recorder that calls |StreamEvent| whenever an event is complete.
-// This recorder does not track Dart objects.
class TimelineEventStreamingRecorder : public TimelineEventRecorder {
public:
TimelineEventStreamingRecorder();
@@ -463,15 +452,12 @@ class TimelineEventStreamingRecorder : public TimelineEventRecorder {
virtual void StreamEvent(TimelineEvent* event) = 0;
protected:
- void VisitObjectPointers(ObjectPointerVisitor* visitor);
- TimelineEvent* StartEvent(const Object& object);
TimelineEvent* StartEvent();
void CompleteEvent(TimelineEvent* event);
};
// A recorder that stores events in chains of blocks of events.
-// This recorder does not track Dart objects.
// NOTE: This recorder will continue to allocate blocks until it exhausts
// memory.
class TimelineEventEndlessRecorder : public TimelineEventRecorder {
@@ -493,8 +479,6 @@ class TimelineEventEndlessRecorder : public TimelineEventRecorder {
void PrintJSON(JSONStream* js);
protected:
- void VisitObjectPointers(ObjectPointerVisitor* visitor);
- TimelineEvent* StartEvent(const Object& object);
TimelineEvent* StartEvent();
void CompleteEvent(TimelineEvent* event);
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698