Switch to a VM wide timeline recorder

Switch to a VM wide timeline recorder

- Initialize and shutdown timeline recorder with VM.
- Allocate global blocks for timeline events without an isolate.
- Stop storing the Stream pointer inside a TimelineEvent.
- Store category name in TimelineEvent.
- Store isolate pointer in TimelineEvent.
- TimelineEventRecorder::WriteTo is full VM dump.
- Allow JSONStream to be used without an isolate.
- When a ThreadRegistry is deleted, Finish all open timeline blocks.
- PrintJSON takes a filter.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/1ff7144c31f75d5d4feda2cd494f44512e2df10d

[Cutch, 2015-08-18 19:24:45]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-08-18 21:09:01]

lgtm w/c

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:52: : ring_(NULL) {
policy_ uninitialized. Mac/Clang build will complain.

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc#...
runtime/vm/timeline.cc:103: timestamp1_ = static_cast<int64_t>(async_id);
Unnecessary cast

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc#...
runtime/vm/timeline.cc:112: timestamp1_ = static_cast<int64_t>(async_id);;
"

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc#...
runtime/vm/timeline.cc:121: timestamp1_ = static_cast<int64_t>(async_id);;
"

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.h
File runtime/vm/timeline.h (right):

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.h#n...
runtime/vm/timeline.h:415: virtual bool VisitBlock(TimelineEventBlock* block) {
'IncludeBlock'?  VisitBlock sounds like it is run for side-effects.

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.h#n...
runtime/vm/timeline.h:423: virtual bool VisitEvent(TimelineEvent* event) {
'IncludeEvent'?

[Cutch, 2015-08-18 21:50:19]

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:52: : ring_(NULL) {
On 2015/08/18 21:09:00, rmacnak wrote:
> policy_ uninitialized. Mac/Clang build will complain.

Done.

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc#...
runtime/vm/timeline.cc:103: timestamp1_ = static_cast<int64_t>(async_id);
On 2015/08/18 21:09:00, rmacnak wrote:
> Unnecessary cast

Done.

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc#...
runtime/vm/timeline.cc:112: timestamp1_ = static_cast<int64_t>(async_id);;
On 2015/08/18 21:09:00, rmacnak wrote:
> "

Done.

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.cc#...
runtime/vm/timeline.cc:121: timestamp1_ = static_cast<int64_t>(async_id);;
On 2015/08/18 21:09:00, rmacnak wrote:
> "

Done.

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.h
File runtime/vm/timeline.h (right):

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.h#n...
runtime/vm/timeline.h:415: virtual bool VisitBlock(TimelineEventBlock* block) {
On 2015/08/18 21:09:00, rmacnak wrote:
> 'IncludeBlock'?  VisitBlock sounds like it is run for side-effects.

Done.

https://codereview.chromium.org/1294023009/diff/20001/runtime/vm/timeline.h#n...
runtime/vm/timeline.h:423: virtual bool VisitEvent(TimelineEvent* event) {
On 2015/08/18 21:09:00, rmacnak wrote:
> 'IncludeEvent'?

Done.

[Cutch, 2015-08-18 22:18:07]

Committed patchset #4 (id:60001) manually as
1ff7144c31f75d5d4feda2cd494f44512e2df10d (presubmit successful).

[Ivan Posva, 2015-08-21 02:25:38]

iposva@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2015-08-21 02:25:38]

DBC -ip

https://codereview.chromium.org/1294023009/diff/60001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1294023009/diff/60001/runtime/vm/dart.cc#newc...
runtime/vm/dart.cc:102: Thread::EnsureInit();
Shouldn't this be called ReallyEnsureInit? Since it is called the second time...