Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: runtime/vm/json_stream.cc

Issue 1294023009: Switch to a VM wide timeline recorder (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/json_stream.cc
diff --git a/runtime/vm/json_stream.cc b/runtime/vm/json_stream.cc
index 9dcb3d5efd199f619d636476ebf5eb3fcfd39969..e0ee6b7280f10bd22e6953f590a290b2ca6056ec 100644
--- a/runtime/vm/json_stream.cc
+++ b/runtime/vm/json_stream.cc
@@ -23,15 +23,20 @@ DECLARE_FLAG(bool, trace_service);
JSONStream::JSONStream(intptr_t buf_size)
: open_objects_(0),
buffer_(buf_size),
- default_id_zone_(Isolate::Current()->object_id_ring(),
- ObjectIdRing::kAllocateId),
+ default_id_zone_(),
id_zone_(&default_id_zone_),
reply_port_(ILLEGAL_PORT),
- seq_(Instance::Handle(Instance::null())),
+ seq_(NULL),
method_(""),
param_keys_(NULL),
param_values_(NULL),
num_params_(0) {
+ ObjectIdRing* ring = NULL;
+ Isolate* isolate = Isolate::Current();
+ if (isolate != NULL) {
+ ring = isolate->object_id_ring();
+ }
+ default_id_zone_.Init(ring, ObjectIdRing::kAllocateId);
}
@@ -46,7 +51,7 @@ void JSONStream::Setup(Zone* zone,
const Array& param_keys,
const Array& param_values) {
set_reply_port(reply_port);
- seq_ ^= seq.raw();
+ seq_ = &Instance::ZoneHandle(seq.raw());
method_ = method.ToCString();
String& string_iterator = String::Handle();
@@ -175,17 +180,17 @@ void JSONStream::PostReply() {
if (FLAG_trace_service) {
process_delta_micros = OS::GetCurrentTimeMicros() - setup_time_micros_;
}
-
- if (seq_.IsString()) {
- const String& str = String::Cast(seq_);
+ ASSERT(seq_ != NULL);
+ if (seq_->IsString()) {
+ const String& str = String::Cast(*seq_);
PrintProperty("id", str.ToCString());
- } else if (seq_.IsInteger()) {
- const Integer& integer = Integer::Cast(seq_);
+ } else if (seq_->IsInteger()) {
+ const Integer& integer = Integer::Cast(*seq_);
PrintProperty64("id", integer.AsInt64Value());
- } else if (seq_.IsDouble()) {
- const Double& dbl = Double::Cast(seq_);
+ } else if (seq_->IsDouble()) {
+ const Double& dbl = Double::Cast(*seq_);
PrintProperty("id", dbl.value());
- } else if (seq_.IsNull()) {
+ } else if (seq_->IsNull()) {
// JSON-RPC 2.0 says that a request with a null ID shouldn't get a reply.
PostNullReply(port);
return;
« runtime/vm/dart.cc ('K') | « runtime/vm/json_stream.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698