Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: runtime/vm/service_isolate.cc

Issue 1294023009: Switch to a VM wide timeline recorder (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service_isolate.cc
diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc
index 3779905093b7a5a401698fb608fec912ad4e4669..177129d36d8941883e62b868a0f7f2d74f87739c 100644
--- a/runtime/vm/service_isolate.cc
+++ b/runtime/vm/service_isolate.cc
@@ -614,6 +614,8 @@ class RunServiceTask : public ThreadPool::Task {
public:
virtual void Run() {
ASSERT(Isolate::Current() == NULL);
+ TimelineDurationScope tds(Timeline::GetVMStream(),
+ "ServiceIsolateStartup");
char* error = NULL;
Isolate* isolate = NULL;
@@ -643,7 +645,6 @@ class RunServiceTask : public ThreadPool::Task {
return;
}
- isolate->RemoveTimelineEventRecorder();
Thread::ExitIsolate();
« runtime/vm/dart.cc ('K') | « runtime/vm/service.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698