Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1292673005: Refactor handling of unqualified static updates. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -33 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +105 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 6 chunks +16 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 8 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-19 11:57:42 UTC) #2
floitsch
LGTM.
5 years, 4 months ago (2015-08-19 14:41:41 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-20 10:44:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
256092eee373ca85a20c90131c6f086fb89aea51 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698