Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: tests/compiler/dart2js/semantic_visitor_test_send_data.dart

Issue 1292673005: Refactor handling of unqualified static updates. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/semantic_visitor_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/semantic_visitor_test_send_data.dart
diff --git a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
index 0419caed0e6a373d117acb4cf3ed9c61117acf3f..ce49bc0271ec21e1a79d2c2b7a982bfd7691d7bf 100644
--- a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
+++ b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
@@ -320,8 +320,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() { o = 42; }
}
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_FINAL_STATIC_FIELD_SET,
+ element: 'field(C#o)',
rhs: '42')),
const Test.clazz(
'''
@@ -358,8 +358,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() { o = 42; }
}
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_FINAL_STATIC_FIELD_SET,
+ element: 'field(C#o)',
rhs: '42')),
const Test.clazz(
'''
@@ -436,8 +436,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() { o = 42; }
}
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_STATIC_GETTER_SET,
+ element: 'getter(C#o)',
rhs: '42')),
const Test.clazz(
'''
@@ -663,8 +663,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() { o = 42; }
}
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_STATIC_FUNCTION_SET,
+ element: 'function(C#o)',
rhs: '42')),
const Test.clazz(
'''
@@ -806,8 +806,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
final o = 0;
m() { o = 42; }
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_FINAL_TOP_LEVEL_FIELD_SET,
+ element: 'field(o)',
rhs: '42')),
const Test.prefix(
'''
@@ -822,8 +822,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
const o = 0;
m() { o = 42; }
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_FINAL_TOP_LEVEL_FIELD_SET,
+ element: 'field(o)',
rhs: '42')),
const Test.prefix(
'''
@@ -896,8 +896,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
get o => null;
m() { o = 42; }
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_SET,
+ element: 'getter(o)',
rhs: '42')),
const Test.prefix(
'''
@@ -1041,8 +1041,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
o(a, b) {}
m() { o = 42; }
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SET,
- name: 'o',
+ const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_SET,
+ element: 'function(o)',
rhs: '42')),
const Test.prefix(
'''
« no previous file with comments | « tests/compiler/dart2js/semantic_visitor_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698