tests/compiler/dart2js/resolver_test.dart - Issue 1292673005: Refactor handling of unqualified static updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/resolver_test.dart

Issue 1292673005: Refactor handling of unqualified static updates. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/resolver_test.dart

diff --git a/tests/compiler/dart2js/resolver_test.dart b/tests/compiler/dart2js/resolver_test.dart

index bb212fefeaab2226eb33affff639a66daade38b3..5aeb9e54514f40b013154335bca8ac07154c7d92 100644

--- a/tests/compiler/dart2js/resolver_test.dart

+++ b/tests/compiler/dart2js/resolver_test.dart

@@ -1227,7 +1227,9 @@ testCantAssignMethods() {

checkWarningOn('''

m() {}

main() { m = 4; }

- ''', [MessageKind.ASSIGNING_METHOD]);

+ ''', [MessageKind.ASSIGNING_METHOD,

+ // TODO(johnniwinther): Avoid duplicate warnings.

+ MessageKind.NOT_ASSIGNABLE]);

// Can't override instance methods

checkWarningOn('''