suggest prefixed constructors - fixes #23210

suggest prefixed constructors - fixes #23210

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/9af696a4f74018139e6c8041d465a97f1d52c798

[danrubel, 2015-08-14 04:36:42]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-08-14 14:49:44]

LGTM

https://codereview.chromium.org/1291283002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart
(right):

https://codereview.chromium.org/1291283002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart:409:
instCreation);
Consider passing in the node and allowing the builder to extract the information
it wants directly.

[danrubel, 2015-08-15 00:32:50]

https://codereview.chromium.org/1291283002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart
(right):

https://codereview.chromium.org/1291283002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart:409:
instCreation);
On 2015/08/14 14:49:44, Brian Wilkerson wrote:
> Consider passing in the node and allowing the builder to extract the
information
> it wants directly.

Good point. I'm hoping to refactor as part of moving to a public API and that
change could be part of it.

[danrubel, 2015-08-15 00:33:09]

Committed patchset #2 (id:20001) manually as
9af696a4f74018139e6c8041d465a97f1d52c798 (presubmit successful).