suggest prefixed constructors - fixes #23210

pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.suggestion.builder;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
 import 'package:analysis_server/src/protocol_server.dart'
     hide Element, ElementKind;
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:path/path.dart' as path;
 
 const String DYNAMIC = 'dynamic';
 
 /**
  * Return a suggestion based upon the given element
  * or `null` if a suggestion is not appropriate for the given element.
  * If the suggestion is not currently in scope, then specify
  * importForSource as the source to which an import should be added.
  */
-CompletionSuggestion createSuggestion(Element element,
-    {CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
+CompletionSuggestion createSuggestion(Element element, {String completion,
+    CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
     int relevance: DART_RELEVANCE_DEFAULT, Source importForSource}) {
   if (element is ExecutableElement && element.isOperator) {
     // Do not include operators in suggestions
     return null;
   }
-  String completion = element.displayName;
+  if (completion == null) {
+    completion = element.displayName;
+  }
   bool isDeprecated = element.isDeprecated;
   CompletionSuggestion suggestion = new CompletionSuggestion(kind,
       isDeprecated ? DART_RELEVANCE_LOW : relevance, completion,
       completion.length, 0, isDeprecated, false);
   suggestion.element = protocol.newElement_fromEngine(element);
   Element enclosingElement = element.enclosingElement;
   if (enclosingElement is ClassElement) {
     suggestion.declaringType = enclosingElement.displayName;
   }
   suggestion.returnType = getReturnTypeString(element);
@@ skipping 136 matching lines @@
   CompletionSuggestionKind get kind;
 
   /**
    * Return the request on which the builder is operating.
    */
   DartCompletionRequest get request;
 
   /**
    * Add a suggestion based upon the given element.
    */
-  void addSuggestion(Element element, {int relevance: DART_RELEVANCE_DEFAULT}) {
+  void addSuggestion(Element element,
+      {String prefix, int relevance: DART_RELEVANCE_DEFAULT}) {
     if (element.isPrivate) {
       LibraryElement elementLibrary = element.library;
       CompilationUnitElement unitElem = request.unit.element;
       if (unitElem == null) {
         return;
       }
       LibraryElement unitLibrary = unitElem.library;
       if (elementLibrary != unitLibrary) {
         return;
       }
     }
-    if (element.isSynthetic) {
+    if (prefix == null && element.isSynthetic) {
       if ((element is PropertyAccessorElement) ||
           element is FieldElement && !_isSpecialEnumField(element)) {
         return;
       }
     }
     String completion = element.displayName;
+    if (prefix != null && prefix.length > 0) {
+      if (completion == null || completion.length <= 0) {
+        completion = prefix;
+      } else {
+        completion = '$prefix.$completion';
+      }
+    }
     if (completion == null || completion.length <= 0) {
       return;
     }
-    CompletionSuggestion suggestion =
-        createSuggestion(element, kind: kind, relevance: relevance);
+    CompletionSuggestion suggestion = createSuggestion(element,
+        completion: completion, kind: kind, relevance: relevance);
     if (suggestion != null) {
       request.addSuggestion(suggestion);
     }
   }
 
   /**
    * Determine if the given element is one of the synthetic enum accessors
    * for which we should generate a suggestion.
    */
   bool _isSpecialEnumField(FieldElement element) {
@@ skipping 207 matching lines @@
 /**
  * This class visits elements in a library and provides suggestions based upon
  * the visible members in that library. Clients should call
  * [LibraryElementSuggestionBuilder.suggestionsFor].
  */
 class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
     with ElementSuggestionBuilder {
   final DartCompletionRequest request;
   final CompletionSuggestionKind kind;
   final bool typesOnly;
+  final bool instCreation;
 
-  LibraryElementSuggestionBuilder(this.request, this.kind, this.typesOnly);
+  LibraryElementSuggestionBuilder(
+      this.request, this.kind, this.typesOnly, this.instCreation);
 
   @override
   visitClassElement(ClassElement element) {
-    addSuggestion(element);
+    if (instCreation) {
+      element.visitChildren(this);
+    } else {
+      addSuggestion(element);
+    }
   }
 
   @override
   visitCompilationUnitElement(CompilationUnitElement element) {
     element.visitChildren(this);
     LibraryElement containingLibrary = element.library;
     if (containingLibrary != null) {
       for (var lib in containingLibrary.exportedLibraries) {
         lib.visitChildren(this);
       }
     }
   }
 
   @override
+  visitConstructorElement(ConstructorElement element) {
+    if (instCreation) {
+      ClassElement classElem = element.enclosingElement;
+      if (classElem != null) {
+        String prefix = classElem.name;
+        if (prefix != null && prefix.length > 0) {
+          addSuggestion(element, prefix: prefix);
+        }
+      }
+    }
+  }
+
+  @override
   visitElement(Element element) {
     // ignored
   }
 
   @override
   visitFunctionElement(FunctionElement element) {
     if (!typesOnly) {
       addSuggestion(element);
     }
   }
 
   @override
   visitFunctionTypeAliasElement(FunctionTypeAliasElement element) {
-    addSuggestion(element);
+    if (!instCreation) {
+      addSuggestion(element);
+    }
   }
 
   @override
   visitTopLevelVariableElement(TopLevelVariableElement element) {
     if (!typesOnly) {
       addSuggestion(element);
     }
   }
 
   /**
    * Add suggestions for the visible members in the given library
    */
   static void suggestionsFor(DartCompletionRequest request,
-      CompletionSuggestionKind kind, LibraryElement library, bool typesOnly) {
+      CompletionSuggestionKind kind, LibraryElement library, bool typesOnly,
+      bool instCreation) {
     if (library != null) {
-      library.visitChildren(
-          new LibraryElementSuggestionBuilder(request, kind, typesOnly));
+      library.visitChildren(new LibraryElementSuggestionBuilder(
+          request, kind, typesOnly, instCreation));
     }
   }
 }
 
 /**
  * This class visits elements in a class and provides suggestions based upon
  * the visible named constructors in that class.
  */
 class NamedConstructorSuggestionBuilder extends GeneralizingElementVisitor
     with ElementSuggestionBuilder implements SuggestionBuilder {
@@ skipping 121 matching lines @@
    * or `false` if [computeFull] should be called.
    */
   bool computeFast(AstNode node);
 
   /**
    * Return a future that computes the suggestions given a fully resolved AST.
    * The future returns `true` if suggestions were added, else `false`.
    */
   Future<bool> computeFull(AstNode node);
 }