suggest prefixed constructors - fixes #23210

pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.contributor.dart.invocation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/local_declaration_visitor.dart';
 import 'package:analysis_server/src/services/completion/local_suggestion_builder.dart'
     hide createSuggestion;
 import 'package:analysis_server/src/services/completion/optype.dart';
 import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
 import 'package:analysis_server/src/services/completion/suggestion_builder.dart'
     show createSuggestion;
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 
 import '../../protocol_server.dart'
     show CompletionSuggestion, CompletionSuggestionKind;
-import '../../protocol_server.dart' as protocol;
 
 /**
  * A contributor for calculating invocation / access suggestions
  * `completion.getSuggestions` request results.
  */
 class PrefixedElementContributor extends DartCompletionContributor {
   SuggestionBuilder builder;
 
   @override
   bool computeFast(DartCompletionRequest request) {
@@ skipping 70 matching lines @@
   final DartCompletionRequest request;
 
   _FieldFormalSuggestionBuilder(this.request);
 
   @override
   bool computeFast(AstNode node) {
     if (node is FieldFormalParameter) {
       ConstructorDeclaration constructorDecl =
           node.getAncestor((p) => p is ConstructorDeclaration);
       if (constructorDecl != null) {
-
         // Compute fields already referenced
         List<String> referencedFields = new List<String>();
         for (FormalParameter param in constructorDecl.parameters.parameters) {
           if (param is FieldFormalParameter) {
             SimpleIdentifier fieldId = param.identifier;
             if (fieldId != null && fieldId != request.target.entity) {
               String fieldName = fieldId.name;
               if (fieldName != null && fieldName.length > 0) {
                 referencedFields.add(fieldName);
               }
@@ skipping 82 matching lines @@
   SuggestionBuilder visitPropertyAccess(PropertyAccess node) {
     return new _ExpressionSuggestionBuilder(request);
   }
 }
 
 /**
  * An [AstVisitor] which looks for a declaration with the given name
  * and if found, tries to determine a type for that declaration.
  */
 class _LocalBestTypeVisitor extends LocalDeclarationVisitor {
-
   /**
    * The name for the declaration to be found.
    */
   final String targetName;
 
   /**
    * The best type for the found declaration,
    * or `null` if no declaration found or failed to determine a type.
    */
   DartType typeFound;
@@ skipping 169 matching lines @@
   @override
   Future<bool> visitPrefixElement(PrefixElement element) {
     bool modified = false;
     // Find the import directive with the given prefix
     for (Directive directive in request.unit.directives) {
       if (directive is ImportDirective) {
         if (directive.prefix != null) {
           if (directive.prefix.name == element.name) {
             // Suggest elements from the imported library
             LibraryElement library = directive.uriElement;
+            AstNode node = request.target.containingNode;
+            bool typesOnly = node.parent is TypeName;
+            bool instCreation =
+                typesOnly && node.parent.parent is ConstructorName;
             LibraryElementSuggestionBuilder.suggestionsFor(request,
-                CompletionSuggestionKind.INVOCATION, library,
-                request.target.containingNode.parent is TypeName);
+                CompletionSuggestionKind.INVOCATION, library, typesOnly,
+                instCreation);
             modified = true;
             if (directive.deferredKeyword != null) {
               FunctionElement loadLibFunct = library.loadLibraryFunction;
               request.addSuggestion(createSuggestion(loadLibFunct));
             }
           }
         }
       }
     }
     return new Future.value(modified);
@@ skipping 10 matching lines @@
     }
     return new Future.value(false);
   }
 
   @override
   Future<bool> visitVariableElement(VariableElement element) {
     InterfaceTypeSuggestionBuilder.suggestionsFor(request, element.type);
     return new Future.value(true);
   }
 }