Issue 1287043007: Fix overly-strict parameter checking of _getCallSiteData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1287043007: Fix overly-strict parameter checking of _getCallSiteData. (Closed)

Created:
5 years, 4 months ago by rmacnak

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix overly-strict parameter checking of _getCallSiteData. Ensure padding between columns in allocation profile. Desaturate the red used for methods with optimization issues. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/82b4f03dec5cbe98aa3510d88dd11e07b8164acb

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -2 lines)			Patch
M	runtime/observatory/lib/src/elements/heap_profile.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/script_inset.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/service.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

5 years, 4 months ago (2015-08-12 22:20:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
82b4f03dec5cbe98aa3510d88dd11e07b8164acb (presubmit successful).