Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: runtime/vm/service.cc

Issue 1287043007: Fix overly-strict parameter checking of _getCallSiteData. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/script_inset.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 342c1a4b1b215a8c5f1ea19035f878dbf70d913e..09676cc1abc6aa4eb08becc1a6e8db51cf4a82f1 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1969,6 +1969,7 @@ static bool GetHitsOrSites(Isolate* isolate, JSONStream* js, bool as_sites) {
static const MethodParameter* get_coverage_params[] = {
ISOLATE_PARAMETER,
+ new IdParameter("targetId", false),
NULL,
};
@@ -1981,7 +1982,7 @@ static bool GetCoverage(Isolate* isolate, JSONStream* js) {
static const MethodParameter* get_call_site_data_params[] = {
ISOLATE_PARAMETER,
- new IdParameter("targetId", true),
+ new IdParameter("targetId", false),
NULL,
};
« no previous file with comments | « runtime/observatory/lib/src/elements/script_inset.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698