Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: runtime/observatory/lib/src/elements/script_inset.dart

Issue 1287043007: Fix overly-strict parameter checking of _getCallSiteData. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/heap_profile.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library script_inset_element; 5 library script_inset_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'observatory_element.dart'; 9 import 'observatory_element.dart';
10 import 'service_ref.dart'; 10 import 'service_ref.dart';
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 tooltip += "\nNot inlinable!"; 286 tooltip += "\nNot inlinable!";
287 } 287 }
288 if (function.deoptimizations > 0) { 288 if (function.deoptimizations > 0) {
289 tooltip += "\nDeoptimized ${function.deoptimizations} times!"; 289 tooltip += "\nDeoptimized ${function.deoptimizations} times!";
290 } 290 }
291 element.title = tooltip; 291 element.title = tooltip;
292 292
293 if (function.isOptimizable == false || 293 if (function.isOptimizable == false ||
294 function.isInlinable == false || 294 function.isInlinable == false ||
295 function.deoptimizations >0) { 295 function.deoptimizations >0) {
296 element.style.backgroundColor = "red"; 296 element.style.backgroundColor = "#EEA7A7"; // Low-saturation red.
297 } 297 }
298 298
299 addLink(element, url); 299 addLink(element, url);
300 } 300 }
301 } 301 }
302 302
303 /// Box with script source code in it. 303 /// Box with script source code in it.
304 @CustomTag('script-inset') 304 @CustomTag('script-inset')
305 class ScriptInsetElement extends ObservatoryElement { 305 class ScriptInsetElement extends ObservatoryElement {
306 @published Script script; 306 @published Script script;
(...skipping 592 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 class SourceInsetElement extends PolymerElement { 899 class SourceInsetElement extends PolymerElement {
900 SourceInsetElement.created() : super.created(); 900 SourceInsetElement.created() : super.created();
901 901
902 @published SourceLocation location; 902 @published SourceLocation location;
903 @published String height = null; 903 @published String height = null;
904 @published int currentPos; 904 @published int currentPos;
905 @published bool inDebuggerContext = false; 905 @published bool inDebuggerContext = false;
906 @published ObservableList variables; 906 @published ObservableList variables;
907 } 907 }
908 908
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/heap_profile.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698