Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1283413002: Fix table cpu profile to work properly with non-dart functions (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix table cpu profile to work properly with non-dart functions BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/71d7d7a4de18e2ff63d6f8e78fc307f5f7001ba8

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -28 lines) Patch
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 4 chunks +26 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +21 lines, -19 lines 1 comment Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +7 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Cutch
https://codereview.chromium.org/1283413002/diff/20001/runtime/observatory/lib/src/elements/service_view.dart File runtime/observatory/lib/src/elements/service_view.dart (right): https://codereview.chromium.org/1283413002/diff/20001/runtime/observatory/lib/src/elements/service_view.dart#newcode81 runtime/observatory/lib/src/elements/service_view.dart:81: return (object) { Quiet the analyzer! https://codereview.chromium.org/1283413002/diff/20001/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart ...
5 years, 4 months ago (2015-08-13 13:43:13 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-08-13 16:43:06 UTC) #3
Cutch
5 years, 4 months ago (2015-08-13 16:46:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
71d7d7a4de18e2ff63d6f8e78fc307f5f7001ba8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698