Fix table cpu profile to work properly with non-dart functions

runtime/observatory/lib/src/elements/cpu_profile.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library cpu_profile_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
 import 'package:observatory/service.dart';
@@ skipping 851 matching lines @@
   Future refresh() {
     _updateTask.queue();
     return new Future.value(null);
   }
 
   render() {
     _updateView();
   }
 
   checkParameters() {
-    var functionId = app.locationManager.uri.queryParameters['functionId'];
-    if (functionId == null) {
-      _focusOnFunction(null);
-      return;
-    }
     if (isolate == null) {
       return;
     }
-    isolate.getObject(functionId).then((func) => _focusOnFunction(func));
+    var functionId = app.locationManager.uri.queryParameters['functionId'];
+    var functionName =
+        app.locationManager.uri.queryParameters['functionName'];
+    if (functionId == '') {
+      // Fallback to searching by name.
+      _focusOnFunction(_findFunction(functionName));
+    } else {
+      if (functionId == null) {
+        _focusOnFunction(null);
+        return;
+      }
+      isolate.getObject(functionId).then((func) => _focusOnFunction(func));
+    }
   }
 
   _clearView() {
     profileTable.clearRows();
     _renderTable();
   }
 
   _updateView() {
     _buildFunctionTable();
     _renderTable();
@@ skipping 15 matching lines @@
     TableSectionElement tableBody = $['profile-table'];
     var row = _findFunctionRow(function);
     if (row == -1) {
       return;
     }
     tableBody.children[row].classes.remove('shake');
     // trigger reflow.
     tableBody.children[row].offsetHeight;
     tableBody.children[row].scrollIntoView(ScrollAlignment.CENTER);
     tableBody.children[row].classes.add('shake');
+    // Focus on clicked function.
+    _focusOnFunction(function);
   }
 
   _clearFocusedFunction() {
     TableSectionElement tableBody = $['profile-table'];
     // Clear current focus.
     if (focusedRow != null) {
       tableBody.children[focusedRow].classes.remove('focused');
     }
     focusedRow = null;
     focusedFunction = null;
   }
 
+  ServiceFunction _findFunction(String functionName) {
+    for (var func in profile.functions) {
+      if (func.function.name == functionName) {
+        return func.function;
+      }
+    }
+    return null;
+  }
+
   _focusOnFunction(ServiceFunction function) {
     if (focusedFunction == function) {
       // Do nothing.
       return;
     }
 
     _clearFocusedFunction();
 
     if (function == null) {
       _updateFunctionTreeView();
@@ skipping 17 matching lines @@
     _buildCallersTable(focusedFunction);
     _buildCalleesTable(focusedFunction);
   }
 
   _onRowClick(TableRowElement tr) {
     var tableBody = $['profile-table'];
     var row = profileTable.rowFromIndex(tableBody.children.indexOf(tr));
     var function = row.values[NameSortedTable.FUNCTION_COLUMN];
     app.locationManager.goReplacingParameters(
         {
-          'functionId': function.id
+          'functionId': function.id,
+          'functionName': function.vmName
         }
     );
   }
 
   _renderTable() {
     profileTable._updateTableView($['profile-table'],
                                   profileTable._makeFunctionRow,
                                   _onRowClick,
                                   NameSortedTable.FUNCTION_SPACER_COLUMNS,
                                   NameSortedTable.FUNCTION_COLUMN);
@@ skipping 214 matching lines @@
       return;
     }
     var tree = profile.loadCodeTree(exclusive ? 'exclusive' : 'inclusive');
     if (tree == null) {
       return;
     }
     var rootRow = new CodeProfileTreeRow(codeTree, null, profile, tree.root);
     codeTree.initialize(rootRow);
   }
 }