 Chromium Code Reviews
 Chromium Code Reviews Issue 1283413002:
  Fix table cpu profile to work properly with non-dart functions  (Closed) 
  Base URL: git@github.com:dart-lang/sdk.git@master
    
  
    Issue 1283413002:
  Fix table cpu profile to work properly with non-dart functions  (Closed) 
  Base URL: git@github.com:dart-lang/sdk.git@master| OLD | NEW | 
|---|---|
| 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a | 
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. | 
| 4 | 4 | 
| 5 library service_object_view_element; | 5 library service_object_view_element; | 
| 6 | 6 | 
| 7 import 'dart:html'; | 7 import 'dart:html'; | 
| 8 import 'package:logging/logging.dart'; | 8 import 'package:logging/logging.dart'; | 
| 9 import 'package:observatory/service.dart'; | 9 import 'package:observatory/service.dart'; | 
| 10 import 'package:observatory/tracer.dart'; | 10 import 'package:observatory/tracer.dart'; | 
| (...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 71 IOHttpServerViewElement element = | 71 IOHttpServerViewElement element = | 
| 72 new Element.tag('io-http-server-view'); | 72 new Element.tag('io-http-server-view'); | 
| 73 element.httpServer = object; | 73 element.httpServer = object; | 
| 74 return element; | 74 return element; | 
| 75 case 'HttpServerConnection': | 75 case 'HttpServerConnection': | 
| 76 IOHttpServerConnectionViewElement element = | 76 IOHttpServerConnectionViewElement element = | 
| 77 new Element.tag('io-http-server-connection-view'); | 77 new Element.tag('io-http-server-connection-view'); | 
| 78 element.connection = object; | 78 element.connection = object; | 
| 79 return element; | 79 return element; | 
| 80 case 'Object': | 80 case 'Object': | 
| 81 switch (object.vmType) { | 81 return (object) { | 
| 
Cutch
2015/08/13 13:43:13
Quiet the analyzer!
 | |
| 82 case 'ICData': | 82 switch (object.vmType) { | 
| 83 ICDataViewElement element = new Element.tag('icdata-view'); | 83 case 'ICData': | 
| 84 element.icData = object; | 84 ICDataViewElement element = new Element.tag('icdata-view'); | 
| 85 return element; | 85 element.icData = object; | 
| 86 case 'Instructions': | 86 return element; | 
| 87 InstructionsViewElement element = | 87 case 'Instructions': | 
| 88 new Element.tag('instructions-view'); | 88 InstructionsViewElement element = | 
| 89 element.instructions = object; | 89 new Element.tag('instructions-view'); | 
| 90 return element; | 90 element.instructions = object; | 
| 91 case 'ObjectPool': | 91 return element; | 
| 92 ObjectPoolViewElement element = new Element.tag('objectpool-view'); | 92 case 'ObjectPool': | 
| 93 element.pool = object; | 93 ObjectPoolViewElement element = new Element.tag('objectpool-view') ; | 
| 94 return element; | 94 element.pool = object; | 
| 95 default: | 95 return element; | 
| 96 ObjectViewElement element = new Element.tag('object-view'); | 96 default: | 
| 97 element.object = object; | 97 ObjectViewElement element = new Element.tag('object-view'); | 
| 98 return element; | 98 element.object = object; | 
| 99 } | 99 return element; | 
| 100 } | |
| 101 }(object); | |
| 100 case 'SocketList': | 102 case 'SocketList': | 
| 101 IOSocketListViewElement element = | 103 IOSocketListViewElement element = | 
| 102 new Element.tag('io-socket-list-view'); | 104 new Element.tag('io-socket-list-view'); | 
| 103 element.list = object; | 105 element.list = object; | 
| 104 return element; | 106 return element; | 
| 105 case 'Socket': | 107 case 'Socket': | 
| 106 IOSocketViewElement element = new Element.tag('io-socket-view'); | 108 IOSocketViewElement element = new Element.tag('io-socket-view'); | 
| 107 element.socket = object; | 109 element.socket = object; | 
| 108 return element; | 110 return element; | 
| 109 case 'WebSocketList': | 111 case 'WebSocketList': | 
| (...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 227 | 229 | 
| 228 dynamic expander() { | 230 dynamic expander() { | 
| 229 return expandEvent; | 231 return expandEvent; | 
| 230 } | 232 } | 
| 231 | 233 | 
| 232 void expandEvent(bool exp, var done) { | 234 void expandEvent(bool exp, var done) { | 
| 233 expand = exp; | 235 expand = exp; | 
| 234 done(); | 236 done(); | 
| 235 } | 237 } | 
| 236 } | 238 } | 
| OLD | NEW |