Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 12790006: Remove support for SDK dependencies. (Closed)

Created:
7 years, 9 months ago by Bob Nystrom
Modified:
7 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for SDK dependencies. BUG=https://code.google.com/p/dart/issues/detail?id=6354 Committed: https://code.google.com/p/dart/source/detail?r=20098

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -255 lines) Patch
D utils/pub/sdk_source.dart View 1 chunk +0 lines, -54 lines 0 comments Download
M utils/pub/system_cache.dart View 3 chunks +1 line, -3 lines 0 comments Download
M utils/pub/validator/dependency.dart View 1 chunk +1 line, -7 lines 2 comments Download
M utils/tests/pub/install/pub_install_test.dart View 1 chunk +4 lines, -8 lines 0 comments Download
D utils/tests/pub/install/sdk/check_out_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D utils/tests/pub/install/sdk/check_out_transitive_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
M utils/tests/pub/sdk_constraint_test.dart View 3 chunks +28 lines, -40 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M utils/tests/pub/update/pub_update_test.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M utils/tests/pub/validator_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M utils/tests/pub/version_solver_test.dart View 5 chunks +1 line, -53 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
I removed the docs for SDK deps yesterday. After this patch, I'll send out a ...
7 years, 9 months ago (2013-03-15 17:16:21 UTC) #1
nweiz
A couple comments, but otherwise LGTM. https://codereview.chromium.org/12790006/diff/1/utils/pub/validator/dependency.dart File utils/pub/validator/dependency.dart (left): https://codereview.chromium.org/12790006/diff/1/utils/pub/validator/dependency.dart#oldcode43 utils/pub/validator/dependency.dart:43: } Should we ...
7 years, 9 months ago (2013-03-15 18:21:54 UTC) #2
Bob Nystrom
Thanks! https://codereview.chromium.org/12790006/diff/1/utils/pub/validator/dependency.dart File utils/pub/validator/dependency.dart (left): https://codereview.chromium.org/12790006/diff/1/utils/pub/validator/dependency.dart#oldcode43 utils/pub/validator/dependency.dart:43: } On 2013/03/15 18:21:54, nweiz wrote: > Should ...
7 years, 9 months ago (2013-03-15 18:31:56 UTC) #3
Bob Nystrom
7 years, 9 months ago (2013-03-15 18:34:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698