Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: utils/tests/pub/version_solver_test.dart

Issue 12790006: Remove support for SDK dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« utils/pub/validator/dependency.dart ('K') | « utils/tests/pub/validator_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/version_solver_test.dart
diff --git a/utils/tests/pub/version_solver_test.dart b/utils/tests/pub/version_solver_test.dart
index 17997564aa6d8f156b705b0a8e036118ebe340cb..bdec057bc2af7bf4d69b6ae5e6025fb6c90ee5ae 100644
--- a/utils/tests/pub/version_solver_test.dart
+++ b/utils/tests/pub/version_solver_test.dart
@@ -69,7 +69,6 @@ Matcher sourceMismatch(String package1, String package2) {
MockSource source1;
MockSource source2;
-Source versionlessSource;
main() {
initConfig();
@@ -151,30 +150,6 @@ main() {
'bang': '1.0.0'
});
- testResolve('from versionless source', {
- 'myapp 0.0.0': {
- 'foo from versionless': 'any'
- },
- 'foo 1.2.3 from versionless': {}
- }, result: {
- 'myapp from root': '0.0.0',
- 'foo from versionless': '1.2.3'
- });
-
- testResolve('transitively through versionless source', {
- 'myapp 0.0.0': {
- 'foo from versionless': 'any'
- },
- 'foo 1.2.3 from versionless': {
- 'bar': '>=1.0.0'
- },
- 'bar 1.1.0': {}
- }, result: {
- 'myapp from root': '0.0.0',
- 'foo from versionless': '1.2.3',
- 'bar': '1.1.0'
- });
-
testResolve('with compatible locked dependency', {
'myapp 0.0.0': {
'foo': 'any'
@@ -426,10 +401,8 @@ testResolve(description, packages, {lockfile, result, Matcher error}) {
var cache = new SystemCache('.');
source1 = new MockSource('mock1');
source2 = new MockSource('mock2');
- versionlessSource = new MockVersionlessSource();
cache.register(source1);
cache.register(source2);
- cache.register(versionlessSource);
cache.sources.setDefault(source1.name);
// Build the test package graph.
@@ -553,30 +526,6 @@ class MockSource extends Source {
}
}
-/// A source used for testing that doesn't natively understand versioning,
-/// similar to how the Git and SDK sources work.
-class MockVersionlessSource extends Source {
- final Map<String, Package> _packages;
-
- final String name = 'versionless';
- final bool shouldCache = false;
-
- MockVersionlessSource()
- : _packages = <String, Package>{};
-
- Future<bool> install(PackageId id, String path) {
- throw 'no';
- }
-
- Future<Pubspec> describe(PackageId id) {
- return new Future<Pubspec>.immediate(_packages[id.description].pubspec);
- }
-
- void addPackage(Package package) {
- _packages[package.name] = package;
- }
-}
nweiz 2013/03/15 18:21:54 I don't understand why we're getting rid of this.
Bob Nystrom 2013/03/15 18:31:56 Per our discussion, I don't think these test anyth
-
void parseSource(String description,
callback(bool isDev, String name, Source source)) {
var isDev = false;
@@ -592,8 +541,7 @@ void parseSource(String description,
var sourceNames = {
'mock1': source1,
'mock2': source2,
- 'root': null,
- 'versionless': versionlessSource
+ 'root': null
};
var match = new RegExp(r"(.*) from (.*)").firstMatch(description);
« utils/pub/validator/dependency.dart ('K') | « utils/tests/pub/validator_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698