Chromium Code Reviews| Index: utils/pub/validator/dependency.dart |
| diff --git a/utils/pub/validator/dependency.dart b/utils/pub/validator/dependency.dart |
| index de027385ffdf75a6b7afc640cbc63482ecfb91a4..d66059decb364025f86d496207100c42b35a4f31 100644 |
| --- a/utils/pub/validator/dependency.dart |
| +++ b/utils/pub/validator/dependency.dart |
| @@ -34,13 +34,7 @@ class DependencyValidator extends Validator { |
| return new Future.immediate(null); |
| } |
| - if (dependency.constraint.isAny && |
| - // TODO(nweiz): once we have development dependencies (issue 5358), we |
| - // should warn about unittest. Until then, it's reasonable not to put |
| - // a constraint on it. |
| - dependency.name != 'unittest') { |
| - _warnAboutConstraint(dependency); |
| - } |
|
nweiz
2013/03/15 18:21:54
Should we maybe suggest that people use a dev depe
Bob Nystrom
2013/03/15 18:31:56
I think the fix for users here is pretty simple, s
|
| + if (dependency.constraint.isAny) _warnAboutConstraint(dependency); |
| return new Future.immediate(null); |
| }); |