Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: utils/pub/validator/dependency.dart

Issue 12790006: Remove support for SDK dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/validator/dependency.dart
diff --git a/utils/pub/validator/dependency.dart b/utils/pub/validator/dependency.dart
index de027385ffdf75a6b7afc640cbc63482ecfb91a4..d66059decb364025f86d496207100c42b35a4f31 100644
--- a/utils/pub/validator/dependency.dart
+++ b/utils/pub/validator/dependency.dart
@@ -34,13 +34,7 @@ class DependencyValidator extends Validator {
return new Future.immediate(null);
}
- if (dependency.constraint.isAny &&
- // TODO(nweiz): once we have development dependencies (issue 5358), we
- // should warn about unittest. Until then, it's reasonable not to put
- // a constraint on it.
- dependency.name != 'unittest') {
- _warnAboutConstraint(dependency);
- }
nweiz 2013/03/15 18:21:54 Should we maybe suggest that people use a dev depe
Bob Nystrom 2013/03/15 18:31:56 I think the fix for users here is pretty simple, s
+ if (dependency.constraint.isAny) _warnAboutConstraint(dependency);
return new Future.immediate(null);
});

Powered by Google App Engine
This is Rietveld 408576698