Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1278803005: Minor observatory test cleanups. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor observatory test cleanups. - Remove --compile-all from a couple of tests. - Use debugger() instead of busy-waiting in a couple of tests. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/fbe47ffa538a99c388d455abe023ad975344fbb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -150 lines) Patch
M runtime/observatory/tests/service/coverage_test.dart View 2 chunks +63 lines, -118 lines 0 comments Download
M runtime/observatory/tests/service/debugger_location_test.dart View 3 chunks +8 lines, -28 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_and_exit_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 4 months ago (2015-08-11 19:56:04 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-11 19:57:38 UTC) #3
turnidge
5 years, 4 months ago (2015-08-11 21:31:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fbe47ffa538a99c388d455abe023ad975344fbb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698