Minor observatory test cleanups.

runtime/observatory/tests/service/debugger_location_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // VMOptions=--error_on_bad_type --error_on_bad_override
 
 import 'package:observatory/service_io.dart';
 import 'package:observatory/debugger.dart';
 import 'package:unittest/unittest.dart';
 import 'test_helper.dart';
 import 'dart:async';
+import 'dart:developer';
 
 void testFunction() {
   int i = 0;
   while (true) {
-    if (++i % 100000000 == 0) {  // line 15
-      print(i);
-    }
+    debugger();
+    print('loop');
+    print('loop');
   }
 }
 
 class TestDebugger extends Debugger {
   TestDebugger(this.isolate, this.stack);
 
   VM get vm => isolate.vm;
   Isolate isolate;
   ServiceMap stack;
   int currentFrame = 0;
@@ skipping 16 matching lines @@
 }
 
 Future<Debugger> initDebugger(Isolate isolate) {
   return isolate.getStack().then((stack) {
     return new TestDebugger(isolate, stack);
   });
 }
 
 var tests = [
 
-// Bring the isolate to a breakpoint at line 15.
-(Isolate isolate) {
-  return isolate.rootLibrary.load().then((_) {
-      // Listen for breakpoint event.
-      Completer completer = new Completer();
-      isolate.vm.getEventStream(VM.kDebugStream).then((stream) {
-        var subscription;
-        subscription = stream.listen((ServiceEvent event) {
-          if (event.kind == ServiceEvent.kPauseBreakpoint) {
-            subscription.cancel();
-            completer.complete();
-          }
-        });
-      });
-
-      // Add the breakpoint.
-      var script = isolate.rootLibrary.scripts[0];
-      return isolate.addBreakpoint(script, 15).then((ServiceObject bpt) {
-          return completer.future;  // Wait for breakpoint events.
-      });
-    });
-},
+hasStoppedAtBreakpoint,
 
 // Parse '' => current position
 (Isolate isolate) {
   return initDebugger(isolate).then((debugger) {
     return DebuggerLocation.parse(debugger, '').then((DebuggerLocation loc) {
       expect(loc.valid, isTrue);
-      expect(loc.toString(), equals('debugger_location_test.dart:15'));
+      expect(loc.toString(), equals('debugger_location_test.dart:17'));
     });
   });
 },
 
 // Parse line
 (Isolate isolate) {
   return initDebugger(isolate).then((debugger) {
-    return DebuggerLocation.parse(debugger, '16').then((DebuggerLocation loc) {
+    return DebuggerLocation.parse(debugger, '18').then((DebuggerLocation loc) {
       expect(loc.valid, isTrue);
-      expect(loc.toString(), equals('debugger_location_test.dart:16'));
+      expect(loc.toString(), equals('debugger_location_test.dart:18'));
     });
   });
 },
 
 // Parse line + col
 (Isolate isolate) {
   return initDebugger(isolate).then((debugger) {
     return DebuggerLocation.parse(debugger, '16:11').then((DebuggerLocation loc) {
       expect(loc.valid, isTrue);
       expect(loc.toString(), equals('debugger_location_test.dart:16:11'));
@@ skipping 173 matching lines @@
     return DebuggerLocation.complete(debugger, 'DebuggerLocationTestFoo.q')
       .then((List<String> completions) {
         expect(completions.toString(), equals('[]'));
       });
   });
 },
 
 ];
 
 main(args) => runIsolateTests(args, tests, testeeConcurrent: testFunction);