Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: runtime/observatory/tests/service/debugger_location_test.dart

Issue 1278803005: Minor observatory test cleanups. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/debugger_location_test.dart
diff --git a/runtime/observatory/tests/service/debugger_location_test.dart b/runtime/observatory/tests/service/debugger_location_test.dart
index 05a9503588379a7c3173a7543f3c07d006ef1630..8d50a5b327537ca6b6f2b25617162a1aa9e9e578 100644
--- a/runtime/observatory/tests/service/debugger_location_test.dart
+++ b/runtime/observatory/tests/service/debugger_location_test.dart
@@ -8,13 +8,14 @@ import 'package:observatory/debugger.dart';
import 'package:unittest/unittest.dart';
import 'test_helper.dart';
import 'dart:async';
+import 'dart:developer';
void testFunction() {
int i = 0;
while (true) {
- if (++i % 100000000 == 0) { // line 15
- print(i);
- }
+ debugger();
+ print('loop');
+ print('loop');
}
}
@@ -51,35 +52,14 @@ Future<Debugger> initDebugger(Isolate isolate) {
var tests = [
-// Bring the isolate to a breakpoint at line 15.
-(Isolate isolate) {
- return isolate.rootLibrary.load().then((_) {
- // Listen for breakpoint event.
- Completer completer = new Completer();
- isolate.vm.getEventStream(VM.kDebugStream).then((stream) {
- var subscription;
- subscription = stream.listen((ServiceEvent event) {
- if (event.kind == ServiceEvent.kPauseBreakpoint) {
- subscription.cancel();
- completer.complete();
- }
- });
- });
-
- // Add the breakpoint.
- var script = isolate.rootLibrary.scripts[0];
- return isolate.addBreakpoint(script, 15).then((ServiceObject bpt) {
- return completer.future; // Wait for breakpoint events.
- });
- });
-},
+hasStoppedAtBreakpoint,
// Parse '' => current position
(Isolate isolate) {
return initDebugger(isolate).then((debugger) {
return DebuggerLocation.parse(debugger, '').then((DebuggerLocation loc) {
expect(loc.valid, isTrue);
- expect(loc.toString(), equals('debugger_location_test.dart:15'));
+ expect(loc.toString(), equals('debugger_location_test.dart:17'));
});
});
},
@@ -87,9 +67,9 @@ var tests = [
// Parse line
(Isolate isolate) {
return initDebugger(isolate).then((debugger) {
- return DebuggerLocation.parse(debugger, '16').then((DebuggerLocation loc) {
+ return DebuggerLocation.parse(debugger, '18').then((DebuggerLocation loc) {
expect(loc.valid, isTrue);
- expect(loc.toString(), equals('debugger_location_test.dart:16'));
+ expect(loc.toString(), equals('debugger_location_test.dart:18'));
});
});
},

Powered by Google App Engine
This is Rietveld 408576698