Issue 12775009: Optimize TypedData operators [] and []= in the same way as ScalarList.

Issue 12775009: Optimize TypedData operators [] and []= in the same way as ScalarList. (Closed)

Created:
7 years, 9 months ago by Florian Schneider

Modified:
7 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, siva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Optimize TypedData in the same way as ScalarList. Committed: https://code.google.com/p/dart/source/detail?r=20002

Patch Set 2 : fixed x64 build and MethodRecognizer #

Total comments: 4

Patch Set 3 : ARM/MIPS build, comments, rebased #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -76 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2	2 chunks	+1 line, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	2 chunks	+1 line, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	9 chunks	+50 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	7 chunks	+21 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	16 chunks	+85 lines, -17 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	13 chunks	+87 lines, -22 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

lgtm https://codereview.chromium.org/12775009/diff/10001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/12775009/diff/10001/runtime/vm/intermediate_language.cc#newcode1964 runtime/vm/intermediate_language.cc:1964: There's an extra blank line here. https://codereview.chromium.org/12775009/diff/10001/runtime/vm/intermediate_language_ia32.cc File ...

7 years, 9 months ago (2013-03-14 10:09:12 UTC) #2

Florian Schneider

Committed patchset #3 manually as r20002 (presubmit successful).

7 years, 9 months ago (2013-03-14 10:39:30 UTC) #3

Florian Schneider

7 years, 9 months ago (2013-03-14 14:03:09 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12775009/diff/10001/runtime/vm/intermediate_l...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/12775009/diff/10001/runtime/vm/intermediate_l...
runtime/vm/intermediate_language.cc:1964: 
On 2013/03/14 10:09:12, kmillikin wrote:
> There's an extra blank line here.

Done.

https://codereview.chromium.org/12775009/diff/10001/runtime/vm/intermediate_l...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/12775009/diff/10001/runtime/vm/intermediate_l...
runtime/vm/intermediate_language_ia32.cc:1283: __ movsxb(result,
element_address);
On 2013/03/14 10:09:12, kmillikin wrote:
> Something's wrong with the indentation there.  Extra space?

Done.

Expand Messages | Collapse Messages