Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 12775009: Optimize TypedData operators [] and []= in the same way as ScalarList. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: ARM/MIPS build, comments, rebased Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 19997)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -941,6 +941,11 @@
intptr_t FlowGraphCompiler::ElementSizeFor(intptr_t cid) {
+ if (RawObject::IsExternalTypedDataClassId(cid)) {
+ return ExternalTypedData::ElementSizeInBytes(cid);
+ } else if (RawObject::IsTypedDataClassId(cid)) {
+ return TypedData::ElementSizeInBytes(cid);
+ }
switch (cid) {
case kArrayCid:
case kImmutableArrayCid:
@@ -979,6 +984,13 @@
intptr_t FlowGraphCompiler::DataOffsetFor(intptr_t cid) {
+ if (RawObject::IsExternalTypedDataClassId(cid)) {
+ // Elements start at offset 0 of the external data.
+ return 0;
+ }
+ if (RawObject::IsTypedDataClassId(cid)) {
+ return TypedData::data_offset();
+ }
switch (cid) {
case kArrayCid:
case kImmutableArrayCid:
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698