runtime/vm/flow_graph_compiler_x64.cc - Issue 12775009: Optimize TypedData operators [] and []= in the same way as ScalarList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 12775009: Optimize TypedData operators [] and []= in the same way as ScalarList. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: ARM/MIPS build, comments, rebased Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_x64.cc

===================================================================

--- runtime/vm/flow_graph_compiler_x64.cc (revision 19997)

+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)

@@ -1542,7 +1542,6 @@

Address FlowGraphCompiler::ExternalElementAddressForIntIndex(

- intptr_t cid,

intptr_t index_scale,

intptr_t index) {

@@ -1551,18 +1550,10 @@

Address FlowGraphCompiler::ExternalElementAddressForRegIndex(

- intptr_t cid,

intptr_t index_scale,

- switch (cid) {

- case kExternalUint8ArrayCid:

- case kExternalUint8ClampedArrayCid:

- return Address(array, index, ToScaleFactor(index_scale), 0);

- default:

- UNIMPLEMENTED();

- return Address(SPREG, 0);

- }

+ return Address(array, index, ToScaleFactor(index_scale), 0);

}

« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »